Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: Always split the pre-ingested DTFile #5945

Merged
merged 2 commits into from
Sep 19, 2022
Merged

storage: Always split the pre-ingested DTFile #5945

merged 2 commits into from
Sep 19, 2022

Conversation

breezewish
Copy link
Member

Signed-off-by: Wish [email protected]

What problem does this PR solve?

Issue Number: ref #5237

What is changed and how it works?

Consider that we received a 2GB-sized snapshot (which may happen when dynamic region is enabled).

  • Improved: In ApplySnapshot, we use ingestBySplit. In this case, 2GB sized snapshot becomes a 2GB sized segment immediately, which causes segment split again. If we pre-split the DTFile, then the segment will be stable and don't need further operations.

  • No change: In IngestSST, we use ingestByColumnFile. In this case, 2GB sized snapshots are all written to the segment delta layer. Even if we split into multiple DTFiles, they are still all written to the segment delta layer (for now). So there will be no changes.

Check List

Tests

  • Unit test
  • Integration test - There are e2e tests to cover the big region scenario.
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 18, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • flowbehappy
  • hehechen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 18, 2022
@breezewish breezewish mentioned this pull request Sep 18, 2022
Closed
@breezewish breezewish changed the title storage: always split the pre-ingested DTFile storage: Always split the pre-ingested DTFile Sep 18, 2022
@wuhuizuo
Copy link
Contributor

/run-unit-test
/run-integration-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 18, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 18, 2022
CalvinNeo
CalvinNeo approved these changes Sep 18, 2022
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@breezewish
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@breezewish: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bd957c7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 19, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Sep 19, 2022

Coverage for changed files

Filename                                                                                                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/Transaction/ApplySnapshot.cpp         301               163    45.85%          12                 0   100.00%         437               195    55.38%         106                71    33.02%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                              301               163    45.85%          12                 0   100.00%         437               195    55.38%         106                71    33.02%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18866      8119             56.96%    219533  83578        61.93%

full coverage report (for internal network access only)

@JaySon-Huang
Copy link
Contributor

/run-integration-test

@ti-chi-bot
Copy link
Member

@breezewish: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Sep 19, 2022

Coverage for changed files

Filename                                                                                                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/Transaction/ApplySnapshot.cpp         301               163    45.85%          12                 0   100.00%         437               195    55.38%         106                71    33.02%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                              301               163    45.85%          12                 0   100.00%         437               195    55.38%         106                71    33.02%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18863      8115             56.98%    219484  83507        61.95%

full coverage report (for internal network access only)

@JaySon-Huang
Copy link
Contributor

/rebuild

@JaySon-Huang
Copy link
Contributor

/run-integration-test

@ti-chi-bot ti-chi-bot merged commit 6bb178c into master Sep 19, 2022
@JaySon-Huang JaySon-Huang deleted the wenxuan/enable_ingest_to_multiple_2 branch September 19, 2022 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flowbehappy flowbehappy flowbehappy approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@CalvinNeo CalvinNeo CalvinNeo approved these changes

@hehechen hehechen hehechen approved these changes

@lidezhu lidezhu Awaiting requested review from lidezhu

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@breezewish @ti-chi-bot @wuhuizuo @sre-bot @JaySon-Huang @flowbehappy @CalvinNeo @hehechen