Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update tiflash proxy #5043

Merged
merged 3 commits into from
Jun 2, 2022
Merged

update tiflash proxy #5043

merged 3 commits into from
Jun 2, 2022

Conversation

Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Jun 1, 2022 •
edited
Loading

Signed-off-by: Lloyd-Pottiger [email protected]

What problem does this PR solve?

Issue Number: ref #4879

Problem Summary:
update proxy to 20220601_161546

What is changed and how it works?

TiKV implement #4879, update proxy to pick recent changes.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@Lloyd-Pottiger
update tiflash proxy
730bb7b 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 1, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CalvinNeo
  • JinheLin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 1, 2022
@Lloyd-Pottiger Lloyd-Pottiger marked this pull request as draft June 1, 2022 08:25
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 1, 2022
@Lloyd-Pottiger
update tiflash proxy
f29b280 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@Lloyd-Pottiger Lloyd-Pottiger marked this pull request as ready for review June 1, 2022 10:08
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 1, 2022
CalvinNeo
CalvinNeo approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 1, 2022
@Lloyd-Pottiger
Copy link
Contributor Author

/cc @CalvinNeo @JinheLin

@ti-chi-bot ti-chi-bot requested review from CalvinNeo and JinheLin June 1, 2022 10:13
@CalvinNeo
Copy link
Member

should we cherry pick this to TiFlash 6.1?

CalvinNeo
CalvinNeo approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Lloyd-Pottiger Lloyd-Pottiger added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Jun 1, 2022
@Lloyd-Pottiger
Copy link
Contributor Author

should we cherry pick this to TiFlash 6.1?

I will pick

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 2, 2022
@Lloyd-Pottiger
Copy link
Contributor Author

Lloyd-Pottiger commented Jun 2, 2022 •
edited
Loading

should we cherry pick this to TiFlash 6.1?

weiwan says we do not need to do that.

@Lloyd-Pottiger Lloyd-Pottiger removed the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Jun 2, 2022
@Lloyd-Pottiger
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@Lloyd-Pottiger: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f29b280

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 2, 2022
@ti-chi-bot
Copy link
Member

@Lloyd-Pottiger: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Lloyd-Pottiger
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@Lloyd-Pottiger: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Jun 2, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18282      9734             46.76%    204967  97592        52.39%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 226dff6 into pingcap:master Jun 2, 2022
@Lloyd-Pottiger Lloyd-Pottiger deleted the updateproxy20220601_161546 branch June 2, 2022 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalvinNeo CalvinNeo CalvinNeo approved these changes

@JinheLin JinheLin JinheLin approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Lloyd-Pottiger @ti-chi-bot @CalvinNeo @sre-bot @JinheLin