-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore delmark when add minmax for pk column (#4746) #4760
ignore delmark when add minmax for pk column (#4746) #4760
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
lines: 43.3% (49974 out of 115347) |
/merge |
@lidezhu: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 1bcfa1e
|
/run-all-tests |
1 similar comment
/run-all-tests |
/run-all-tests |
/run-all-tests |
/rebuild |
/run-integration-test |
lines: 43.3% (49975 out of 115347) |
/run-integration-test |
This is an automated cherry-pick of #4746
What problem does this PR solve?
Issue Number: close #4747
Problem Summary:
If rows in a stable pack is all mark deleted, then it's minmax index for pk column is both 0.
And when
dt_enable_skippable_place
is enabled and try to place delta index on this segment, it will filter out all pack which is not in the pk range [start_key, +infinite). So the previous stable pack is ignored.But for the place delta index algorithm, it's expected that all the rows in the pk range [start_key, +infinite) is placed no matter whether it's deleted. So when we try to read this segment using the placed delta index, it reports error like "DeltaMerge return wrong result"
What is changed and how it works?
Ignore delmark when add minmax for pk column.
Check List
Tests
Side effects
Documentation
Release note