Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cast to decimal overflow bug (#3922) #4082

Merged
merged 10 commits into from
Apr 26, 2022
Merged

Fix cast to decimal overflow bug (#3922) #4082

merged 10 commits into from
Apr 26, 2022

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Feb 21, 2022 •
edited by guo-shaoge
Loading

This is an automated cherry-pick of #3922

What problem does this PR solve?

Issue Number: close #3920

Problem Summary: todo

What is changed and how it works?

  1. DAGContext.h/.cpp: expose TiDBSQLFLags so we can use it in unittest(TIDBSQLFlags::OVERFLOW_AS_WARNING). Also fix one clang-tidy.
  2. FunctionsTiDBConversion.h: fix the logic that check if overflow happens or not. We should compare inner_value with inner_max_value or out_value with outer_max_value. I choose inner_value here.
  3. gtest_tidb_conversion.cpp: add unit test when overflow happens.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix cast to decimal overflow bug

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 21, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Feb 21, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SeaRise
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. labels Feb 21, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 14, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 21, 2022
@JaySon-Huang JaySon-Huang added this to the v5.4.1 milestone Apr 21, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 25, 2022
@guo-shaoge
fix conflicts
788d32f 
Signed-off-by: guo-shaoge <[email protected]>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 25, 2022
@guo-shaoge
add fullstack case
5c778fd 
Signed-off-by: guo-shaoge <[email protected]>
@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 25, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 25, 2022
@guo-shaoge
Copy link
Contributor

/run-all-tests

@guo-shaoge
Copy link
Contributor

/run-unit-test

@guo-shaoge
fix case
88624ad 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
Merge branch 'cherry-pick-3922-to-release-5.4' of github.com:ti-chi-b…
ce2a2df 
…ot/tiflash into cherry-pick-3922-to-release-5.4
@ti-chi-bot ti-chi-bot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 25, 2022
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 25, 2022
@guo-shaoge
Copy link
Contributor

/run-all-tests

2 similar comments
@guo-shaoge
Copy link
Contributor

/run-all-tests

@guo-shaoge
Copy link
Contributor

/run-all-tests

@guo-shaoge
Copy link
Contributor

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 26, 2022

lines: 43.3% (49979 out of 115355)
branches: 6.5% (81804 out of 1265311)

@guo-shaoge
Copy link
Contributor

/cc @windtalker @SeaRise

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 26, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 26, 2022
@guo-shaoge
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

@guo-shaoge: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: ecadc90

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 26, 2022
@guo-shaoge
Copy link
Contributor

/run-all-tests

1 similar comment
@guo-shaoge
Copy link
Contributor

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 26, 2022

lines: 43.3% (49982 out of 115357)
branches: 6.5% (81804 out of 1265311)

@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 26, 2022

lines: 43.3% (49979 out of 115363)
branches: 6.5% (81806 out of 1265325)

@ti-chi-bot ti-chi-bot merged commit 06e5081 into pingcap:release-5.4 Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeaRise SeaRise SeaRise approved these changes

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@windtalker windtalker Awaiting requested review from windtalker

Assignees

@guo-shaoge guo-shaoge

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.
Projects
None yet
Milestone
v5.4.1
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-chi-bot @guo-shaoge @sre-bot @wshwsh12 @SeaRise @JaySon-Huang @VelocityLight