Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix null case for GetJsonLength #3734

Merged
merged 3 commits into from
Dec 23, 2021
Merged

fix null case for GetJsonLength #3734

merged 3 commits into from
Dec 23, 2021

Conversation

SchrodingerZhu
Copy link
Contributor

Signed-off-by: SchrodingerZhu [email protected]

What problem does this PR solve?

Issue Number: close #2705

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 23, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • solotzg

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 23, 2021
@SchrodingerZhu
fix null case for GetJsonLength
619e177 
Signed-off-by: SchrodingerZhu <[email protected]>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 23, 2021
@SchrodingerZhu
format
d4e41ea 
Signed-off-by: SchrodingerZhu <[email protected]>
@SchrodingerZhu
address CR
d37c76e 
Signed-off-by: SchrodingerZhu <[email protected]>
@JaySon-Huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d37c76e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 23, 2021
@JaySon-Huang JaySon-Huang added needs-cherry-pick-release-4.0 PR which needs to be cherry-picked to release-4.0 needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 labels Dec 23, 2021
@sre-bot
Copy link
Collaborator

sre-bot commented Dec 23, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/597/cobertura/
(Coverage detail url is limited office network access)

lines: 42.6% (47926 out of 112377)
branches: 6.1% (73485 out of 1210502)

@ti-chi-bot ti-chi-bot merged commit 6a60ff4 into pingcap:master Dec 23, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 23, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3735.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 23, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3736.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 23, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3737.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 23, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3738.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 23, 2021
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3739.

ti-chi-bot added a commit that referenced this pull request Jan 24, 2022
@ti-chi-bot
fix null case for GetJsonLength (#3734) (#3736)
b2d914a
ti-chi-bot added a commit that referenced this pull request Apr 14, 2022
@ti-chi-bot
fix null case for GetJsonLength (#3734) (#3737)
d35821a 
close #2705
ti-chi-bot added a commit that referenced this pull request Jun 15, 2022
@ti-chi-bot
fix null case for GetJsonLength (#3734) (#3735)
bc8f47c 
close #2705
ti-chi-bot added a commit that referenced this pull request Jun 15, 2022
@ti-chi-bot
fix null case for GetJsonLength (#3734) (#3738)
7143242 
close #2705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@solotzg solotzg solotzg approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 PR which needs to be cherry-picked to release-4.0 needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Index out of bounds in json_length
5 participants
@SchrodingerZhu @ti-chi-bot @JaySon-Huang @sre-bot @solotzg