FLASH-760: Fix region data not properly released caused by not pre-decoding snapshot regions #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zanmato1984
commented
Dec 11, 2019
zanmato1984
commented
- Fix region data caused not properly released caused by not pre-decoding snapshot regions;
- Add some log messages;
- Fix a mis-used mutex.
zanmato1984
changed the title
solotzg
reviewed
Dec 11, 2019
| @@ -47,9 +49,12 @@ RaftService::RaftService(DB::Context & db_context_) | |||
| data_reclaim_handle = background_pool.addTask([this] { | |||
| std::list<RegionDataReadInfoList> tmp; | |||
| { | |||
| std::lock_guard<std::mutex> lock(region_mutex); | |||
| std::lock_guard<std::mutex> lock(reclaim_mutex); | |||
There was a problem hiding this comment.
I think it is better to keep this one and remove all other modification, otherwise too much log will be printed.
problem about pre-decode has been fixed: 78cbec9#diff-84ac5313afde15e37710c71494637ffbR158
|
I also fix the problem about mutex in #352 . What about closing this pr and merge that? |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.