Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building tiflash using centos7 for official release #343

Merged
merged 4 commits into from
Dec 19, 2019
Merged

Building tiflash using centos7 for official release #343

merged 4 commits into from
Dec 19, 2019

Conversation

marsishandsome
Copy link
Contributor

@marsishandsome marsishandsome commented Dec 6, 2019 •
edited
Loading

run make image_builder to build tiflash builder docker image
run make build_release to build tiflash for release
run make image_tiflash to build tiflash docker image

@marsishandsome marsishandsome changed the title build tiflash using centos7 building tiflash using centos7 Dec 6, 2019
@marsishandsome
Copy link
Contributor Author

/run-integration-tests

@marsishandsome marsishandsome force-pushed the feature/centos7 branch 5 times, most recently from 6129dba to 8031324 Compare December 9, 2019 14:06
@marsishandsome
Copy link
Contributor Author

/run-integration-tests

@marsishandsome marsishandsome force-pushed the feature/centos7 branch 11 times, most recently from cbeb4c9 to 42981ff Compare December 13, 2019 07:29
@marsishandsome marsishandsome changed the title building tiflash using centos7 [WIP] building tiflash using centos7 Dec 13, 2019
@marsishandsome marsishandsome force-pushed the feature/centos7 branch 9 times, most recently from b8af8a2 to 0cb070b Compare December 13, 2019 09:43
@marsishandsome marsishandsome force-pushed the feature/centos7 branch 4 times, most recently from b78e2e6 to bc3648a Compare December 16, 2019 09:41
@marsishandsome marsishandsome changed the title [WIP] building tiflash using centos7 [WIP] building tiflash using centos7 for official release Dec 16, 2019
@marsishandsome marsishandsome changed the title [WIP] building tiflash using centos7 for official release Building tiflash using centos7 for official release Dec 16, 2019
@marsishandsome marsishandsome force-pushed the feature/centos7 branch 4 times, most recently from 329caa8 to 4131572 Compare December 18, 2019 03:36
@marsishandsome
Copy link
Contributor Author

/run-integration-tests

innerr
innerr reviewed Dec 18, 2019
View reviewed changes
release-centos7/build/build-tiflash.sh

cp -f "$build_dir/dbms/src/Server/theflash" "$install_dir/theflash"

ldd "$build_dir/dbms/src/Server/theflash" | grep '/' | grep '=>' | \
Copy link
Contributor

@innerr innerr Dec 18, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto gen .so list vs Hand-picked list:
Auto gen may cp too many .so, which cause other version-conflicting problems, it happened before

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this before in publish.sh, you may have a look at that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this script is only for building a release package, too many .so is ok.
the ansible script will decide which .so will be deployed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK then

innerr
innerr approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@innerr innerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Highly recommand that use set -euo pipefail at the beginning of all scripts, the rest LGTM

@marsishandsome
Copy link
Contributor Author

/run-integration-tests

1 similar comment
@marsishandsome
Copy link
Contributor Author

/run-integration-tests

@marsishandsome marsishandsome merged commit 148b3c1 into pingcap:master Dec 19, 2019
@CalvinNeo CalvinNeo mentioned this pull request Jul 24, 2023
Merged
12 tasks
@CalvinNeo CalvinNeo mentioned this pull request Nov 7, 2024
Closed
12 tasks
yongman added a commit to yongman/tiflash that referenced this pull request Jan 23, 2025
@yongman
bump proxy update kvengine (pingcap#343)
ff3855a 
Signed-off-by: yongman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innerr innerr innerr approved these changes

@zyxbest zyxbest Awaiting requested review from zyxbest

@zanmato1984 zanmato1984 Awaiting requested review from zanmato1984

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marsishandsome @innerr