Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flash-697] SelectExecutor: get safe point with retry. #324

Merged
merged 1 commit into from
Nov 20, 2019
Merged

[flash-697] SelectExecutor: get safe point with retry. #324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dbms/src/Storages/MergeTree/MergeTreeDataSelectExecutor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -835,7 +835,7 @@ BlockInputStreams MergeTreeDataSelectExecutor::read(const Names & column_names_t
{
TMTContext & tmt = context.getTMTContext();

auto safe_point = tmt.getPDClient()->getGCSafePoint();
auto safe_point = PDClientHelper::getGCSafePointWithRetry(tmt.getPDClient());
if (mvcc_query_info.read_tso < safe_point)
throw Exception("query id: " + context.getCurrentQueryId() + ", read tso: " + toString(mvcc_query_info.read_tso)
+ " is smaller than tidb gc safe point: " + toString(safe_point),
Expand Down