Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flash-365] support db filters #164

Merged
merged 7 commits into from
Aug 8, 2019
Merged

[flash-365] support db filters #164

merged 7 commits into from
Aug 8, 2019

Conversation

hanfei1991
Copy link
Member

No description provided.

@hanfei1991 hanfei1991 requested a review from zanmato1984 August 7, 2019 06:12
@@ -95,6 +100,8 @@ class MockTiDB : public ext::singleton<MockTiDB>

Int64 getVersion() { return version; }

std::vector<String> getTableNames(const String & db_name);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use void traverseTables(std::function<void(TablePtr)> f) instead of making new function.

@hanfei1991
Copy link
Member Author

./run-integration-tests

Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanmato1984 zanmato1984 merged commit 8997bd3 into master Aug 8, 2019
@zanmato1984 zanmato1984 deleted the hanfei-ddl/db_filter branch August 8, 2019 05:46
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants