Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String column decoder reserves much larger memory than needed #7416

Closed
yibin87 opened this issue May 5, 2023 · 0 comments · Fixed by #7418
Closed

String column decoder reserves much larger memory than needed #7416

yibin87 opened this issue May 5, 2023 · 0 comments · Fixed by #7418
Assignees
@yibin87
Labels
affects-6.4 affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-6.6 affects-7.0 affects-7.1 This bug affects the 7.1.x(LTS) versions. component/compute severity/major type/bug The issue is confirmed as a bug.

Comments

@yibin87
Copy link
Contributor

yibin87 commented May 5, 2023 •
edited
Loading

Bug Report

When decode columns, we use IColumn's reserve(size_t rows) interface to avoid reallocating memories each time. However, for string columns, the element size is not fixed, and we used 64 bytes as default value. This will lead to much larger memory usage when actual element size is much smaller than 64 bytes.
This problem will be worsen for Join operator, since all build side's blocks will be in memory for a while.
@yibin87 yibin87 added type/bug The issue is confirmed as a bug. severity/major component/compute affects-6.4 affects-7.1 This bug affects the 7.1.x(LTS) versions. labels May 5, 2023
@yibin87 yibin87 self-assigned this May 5, 2023
@yibin87 yibin87 mentioned this issue May 5, 2023
Merged
12 tasks
@windtalker windtalker added affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-6.6 affects-7.0 labels May 5, 2023
This was referenced May 5, 2023
Merged
Merged
@yibin87 yibin87 changed the title String column decode reserved much larger memory than needed String column decoder reserved much larger memory than needed May 6, 2023
@yibin87 yibin87 changed the title String column decoder reserved much larger memory than needed String column decoder reserves much larger memory than needed May 6, 2023
ti-chi-bot bot pushed a commit that referenced this issue May 6, 2023
@ti-chi-bot
Donot reserve memory for non-fixed type columns in decodeAndSquash (#…
3eed664 
…7418) (#7423)

close #7416
ti-chi-bot bot pushed a commit that referenced this issue May 6, 2023
@ti-chi-bot
Donot reserve memory for non-fixed type columns in decodeAndSquash (#…
401933f 
…7418) (#7420)

close #7416
@XuHuaiyu XuHuaiyu mentioned this issue Jun 7, 2023
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yibin87 yibin87

Labels
affects-6.4 affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-6.6 affects-7.0 affects-7.1 This bug affects the 7.1.x(LTS) versions. component/compute severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Donot reserve memory for non-fixed type columns in decodeAndSquash yibin87/tiflash
2 participants
@windtalker @yibin87