Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated apply snapshot method #4998

Closed
JaySon-Huang opened this issue May 25, 2022 · 1 comment · Fixed by #5004
Closed

Remove deprecated apply snapshot method #4998

JaySon-Huang opened this issue May 25, 2022 · 1 comment · Fixed by #5004
Assignees
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented May 25, 2022

Enhancement

Before v5.1, we apply snapshot by decoding SSTFiles into blocks and flush to the storage layer. Since 5.1, by default we decode SSTFiles into DTFiles and ingest to the storage layer, which consume less memory. #1347

We can remove related code of SnapshotApplyMethod::Block now.

[raft.snapshot]
# The way to apply snapshot data
# The value is one of "block" / "file1"
# method = "file1"

@JaySon-Huang JaySon-Huang added the type/enhancement The issue or PR belongs to an enhancement. label May 25, 2022
@hongyunyan
Copy link
Contributor

/assign hongyunyan

@hongyunyan hongyunyan mentioned this issue May 26, 2022
12 tasks
ti-chi-bot pushed a commit that referenced this issue May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants