Merge missed decimal divide fix

Signed-off-by: yibin <[email protected]>

dbms/src/Functions/divide.cpp

@@ -88,7 +88,7 @@ struct TiDBDivideFloatingImpl<A, B, false>
             res_null = 1;
             return static_cast<Result>(0);
         }
-        return static_cast<Result>(a) / b;
+        return apply<Result>(a, b);
     }
 };
 
@@ -115,7 +115,7 @@ struct TiDBDivideFloatingImpl<A, B, true>
             res_null = 1;
             return static_cast<Result>(0);
         }
-        return static_cast<Result>(a) / static_cast<Result>(b);
+        return apply<Result>(a, b);
     }
 };
 

tests/tidb-ci/fullstack-test-dt/issue_1425.test

@@ -2,14 +2,21 @@ mysql> drop table if exists test.t;
 
 mysql> create table test.t (id int, value decimal(7,4), c1 int, c2 int);
 
-mysql> insert into test.t values(1,1.9286,54,28);
+mysql> insert into test.t values (1,1.9285,54,28), (1,1.9286,54,28);
 
 mysql> alter table test.t set tiflash replica 1;
 
 func> wait_table test t
 
+# note: ref to https://github.com/pingcap/tiflash/issues/1682,
+# The precision of tiflash results is different from that of tidb, which is a compatibility issue
 mysql> use test; set session tidb_isolation_read_engines='tiflash'; select * from t where value = 54/28;
 
 mysql> use test; set session tidb_isolation_read_engines='tiflash'; select * from t where value = c1/c2;
++------+--------+------+------+
+| id   | value  | c1   | c2   |
++------+--------+------+------+
+|    1 | 1.9286 |   54 |   28 |
++------+--------+------+------+
 
 mysql> drop table if exists test.t;