Re-enable jemalloc's background thread by default (#9813) (#9814)

ref #9722, close #9812 Re-enable jemalloc's background thread by default Signed-off-by: ti-chi-bot <[email protected]> Signed-off-by: JaySon-Huang <[email protected]> Co-authored-by: Calvin Neo <[email protected]> Co-authored-by: JaySon-Huang <[email protected]> Co-authored-by: JaySon <[email protected]>
pingcap · Jan 23, 2025 · 65a91a3 · 65a91a3
1 parent 3034774
commit 65a91a3
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/dbms/src/Server/Server.cpp b/dbms/src/Server/Server.cpp
@@ -379,10 +379,10 @@ void UpdateMallocConfig([[maybe_unused]] const LoggerPtr & log)
     RUN_FAIL_RETURN(je_mallctl("opt.background_thread", (void *)&old_b, &sz_b, nullptr, 0));
     RUN_FAIL_RETURN(je_mallctl("opt.max_background_threads", (void *)&old_max_thd, &sz_st, nullptr, 0));
 
-    LOG_INFO(log, "Got jemalloc config: opt.background_thread {}, opt.max_background_threads {}", old_b, old_max_thd);
-
-    if (!malloc_conf && !old_b)
+    bool not_config_bg = !malloc_conf || strstr(malloc_conf, "background_thread") == nullptr;
+    if (not_config_bg && !old_b)
     {
+        // If the user doesn't explicitly set the background_thread opt, and it is actually false, then set it to true.
         LOG_INFO(log, "Try to use background_thread of jemalloc to handle purging asynchronously");
 
         RUN_FAIL_RETURN(je_mallctl("max_background_threads", nullptr, nullptr, (void *)&new_max_thd, sz_st));