Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: fix incompatible issue for builtin function str_to_date #9693

Merged
merged 3 commits into from
Mar 14, 2019

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Mar 13, 2019

What problem does this PR solve?

Fix #9666

What is changed and how it works?

Fix incompatible problems on specifier %H, %I, %i, %s, %S and %f.

Check List

Tests

  • Unit test

@qw4990 qw4990 changed the title Fix issue that StrToDate is incompatible with Mysql util/types: Fix issue that StrToDate is incompatible with Mysql Mar 13, 2019
@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #9693 into master will decrease coverage by 0.0076%.
The diff coverage is 66.6666%.

@@               Coverage Diff               @@
##            master      #9693        +/-   ##
===============================================
- Coverage   67.398%   67.3904%   -0.0077%     
===============================================
  Files          377        377                
  Lines        79434      79443         +9     
===============================================
  Hits         53537      53537                
- Misses       21117      21123         +6     
- Partials      4780       4783         +3

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 14, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 14, 2019
@zz-jason zz-jason changed the title util/types: Fix issue that StrToDate is incompatible with Mysql types: fix incompatible issue for builtin function str_to_date Mar 14, 2019
@zz-jason zz-jason merged commit b76b2da into pingcap:master Mar 14, 2019
qw4990 added a commit to qw4990/tidb that referenced this pull request Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants