planner, executor: check col.OrigColName instead of col.ColName in isCoveringIndex #9637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winoros
reviewed
Mar 11, 2019
planner/core/find_best_task.go
Outdated
| @@ -423,7 +423,8 @@ func isCoveringIndex(columns []*expression.Column, indexColumns []*model.IndexCo | |||
| isIndexColumn := false | |||
| for _, indexCol := range indexColumns { | |||
| isFullLen := indexCol.Length == types.UnspecifiedLength || indexCol.Length == col.RetType.Flen | |||
| if col.ColName.L == indexCol.Name.L && isFullLen { | |||
| // We use col.OrigColName instead of col.ColName | |||
There was a problem hiding this comment.
I think adding the issue link here can help others to understand.
zz-jason
reviewed
Mar 11, 2019
| @@ -423,7 +423,8 @@ func isCoveringIndex(columns []*expression.Column, indexColumns []*model.IndexCo | |||
| isIndexColumn := false | |||
| for _, indexCol := range indexColumns { | |||
| isFullLen := indexCol.Length == types.UnspecifiedLength || indexCol.Length == col.RetType.Flen | |||
| if col.ColName.L == indexCol.Name.L && isFullLen { | |||
| // We use col.OrigColName instead of col.ColName | |||
| if col.OrigColName.L == indexCol.Name.L && isFullLen { | |||
There was a problem hiding this comment.
Are there other places which use col.ColName.L instead of col.OrigColName.L?
There was a problem hiding this comment.
I'm not sure.
It needs to be checked.
There was a problem hiding this comment.
Can we check UniqueID here for this case?
There was a problem hiding this comment.
No... There's no place store the result converting model.IndexInfo.Columns to expression.Columns. So in many places we use model.IndexColumn directly compares with expression.Column
|
/run-all-tests |
|
/run-integration-ddl-test |
Codecov Report
@@ Coverage Diff @@
## master #9637 +/- ##
===============================================
- Coverage 67.374% 67.3731% -0.0009%
===============================================
Files 376 376
Lines 79262 79263 +1
===============================================
Hits 53402 53402
Misses 21089 21089
- Partials 4771 4772 +1 |
XuHuaiyu
added a commit
to XuHuaiyu/tidb
that referenced
this pull request
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #9636
What is changed and how it works?
Checking col.OrigColName instead of col.ColName in isCoveringIndex
Check List
Tests
Code changes
Side effects
N/A
Related changes