sessionctx: change "server_uuid" fake value #9434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @GregoryIan (for the remote chance it affects tools), @jackysp |
Codecov Report
@@ Coverage Diff @@
## master #9434 +/- ##
================================================
- Coverage 67.3955% 67.3917% -0.0038%
================================================
Files 377 377
Lines 79345 79345
================================================
- Hits 53475 53472 -3
- Misses 21098 21102 +4
+ Partials 4772 4771 -1 |
zz-jason
added
status/LGT2
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
TiDB lies about certain variables to be compatible with MySQL. The current
server_uuidvalue looks so specific, that it is not clear it is for compatibility.It confused a user I was speaking to.
What is changed and how it works?
I've changed the dummy value from something specific to all zeros. It is a very small change, but is less likely to confuse users since it looks like something uninitialized vs a working feature.
Check List
Tests
Code changes
Side effects
Related changes