-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl, util: Handle default values for generating column expressions when adding an index #9371
Conversation
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #9371 +/- ##
==========================================
+ Coverage 67.41% 67.42% +<.01%
==========================================
Files 373 373
Lines 78557 78557
==========================================
+ Hits 52962 52966 +4
+ Misses 20840 20837 -3
+ Partials 4755 4754 -1
Continue to review full report at Codecov.
|
PTAL @winkyao @crazycs520 |
1 similar comment
PTAL @winkyao @crazycs520 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
…en adding an index (pingcap#9371)
What problem does this PR solve?
Fix #9311
Before this PR:
Now:
What is changed and how it works?
Add default value and handle value to the row before evaluating the generated expression.
Check List
Tests
Code changes
Related changes