Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "gcworker: let gofail in gcworker run serially, make ci happy" #8944

Merged
merged 7 commits into from
Jan 7, 2019
Merged

Revert "gcworker: let gofail in gcworker run serially, make ci happy" #8944

merged 7 commits into from
Jan 7, 2019

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Jan 4, 2019 •
edited by c4pt0r
Loading

Reverts #8912

We don't set CustomParallelSuiteFlag to true. So the tests are originally serially executed in gc_worker_test.go.

This change is Reviewable

@zimulala
Copy link
Contributor Author

zimulala commented Jan 4, 2019

PTAL @winkyao @lonng

@zimulala
Copy link
Contributor Author

zimulala commented Jan 4, 2019

/run-all-tests

@zimulala
Copy link
Contributor Author

zimulala commented Jan 4, 2019

/run-common-test
/run-integration-common-test

@codecov-io
Copy link

codecov-io commented Jan 4, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@78a51a4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8944   +/-   ##
=========================================
  Coverage          ?   67.52%           
=========================================
  Files             ?      363           
  Lines             ?    75111           
  Branches          ?        0           
=========================================
  Hits              ?    50717           
  Misses            ?    19916           
  Partials          ?     4478

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78a51a4...76caa56. Read the comment docs.

winkyao
winkyao reviewed Jan 6, 2019
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zz-jason
zz-jason approved these changes Jan 6, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 6, 2019
@shenli
Copy link
Member

shenli commented Jan 6, 2019

/run-all-tests

@zimulala zimulala merged commit 243d611 into master Jan 7, 2019
@ngaut ngaut deleted the revert-8912-fix_gofail_parallel branch January 9, 2019 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winkyao winkyao winkyao left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
component/test status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zimulala @codecov-io @shenli @zz-jason @winkyao