Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: make errcheck work again (#8795) #8919

Merged
merged 1 commit into from
Jan 3, 2019
Merged

*: make errcheck work again (#8795) #8919

merged 1 commit into from
Jan 3, 2019

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Jan 3, 2019 •
edited by c4pt0r
Loading

Cherry-pick from #8795 and fix errcheck

This change is Reviewable

@tiancaiamao
Copy link
Contributor Author

@winkyao @lysu @winoros

winoros
winoros reviewed Jan 3, 2019
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

zimulala
zimulala approved these changes Jan 3, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 3, 2019
@zimulala
Copy link
Contributor

zimulala commented Jan 3, 2019

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@ngaut ngaut merged commit 271e60a into pingcap:release-2.1 Jan 3, 2019
@tiancaiamao tiancaiamao deleted the errcheck-2.1-pick branch January 4, 2019 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiancaiamao @zimulala @winoros @ngaut