executor: support "show create table" for View #8865

AndrewDi · 2018-12-28T12:59:06Z

What problem does this PR solve?

Modify SHOW CREATE TABLE to show view definition

What is changed and how it works?

ref proposal Proposal: Implement View

Check List

Tests

Unit test

This change is

zz-jason · 2019-01-05T13:41:58Z

@AndrewDi Is this PR still work in progress? Can we begin to review it?

AndrewDi · 2019-01-05T13:43:47Z

@zz-jason main code is complete, you can review now.

codecov-io · 2019-01-05T13:54:36Z

Codecov Report

Merging #8865 into master will decrease coverage by <.01%.
The diff coverage is 64.51%.

@@            Coverage Diff             @@
##           master    #8865      +/-   ##
==========================================
- Coverage   67.26%   67.25%   -0.01%     
==========================================
  Files         371      371              
  Lines       76195    76223      +28     
==========================================
+ Hits        51252    51266      +14     
- Misses      20412    20422      +10     
- Partials     4531     4535       +4

Impacted Files	Coverage Δ
ddl/ddl_api.go	`74.74% <0%> (-0.32%)`	⬇️
executor/show.go	`42.72% <100%> (+1.33%)`	⬆️
planner/core/planbuilder.go	`50.04% <55.55%> (-0.09%)`	⬇️
ddl/delete_range.go	`74.28% <0%> (-4.58%)`	⬇️
executor/distsql.go	`72.53% <0%> (-0.47%)`	⬇️
util/filesort/filesort.go	`76.48% <0%> (+0.31%)`	⬆️
expression/schema.go	`94.95% <0%> (+0.84%)`	⬆️
store/tikv/lock_resolver.go	`42.65% <0%> (+0.94%)`	⬆️
util/systimemon/systime_mon.go	`100% <0%> (+20%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41838ce...7e6eff5. Read the comment docs.

XuHuaiyu

Please add some test cases for this commit.

zz-jason · 2019-01-07T08:41:50Z

@XuHuaiyu Let's review the main code logic firstly.

executor/show.go

eurekaka · 2019-01-07T09:22:04Z

executor/show.go

 		}
+		fmt.Fprintf(&buf, ") AS %s", tb.Meta().View.SelectStmt)


This is the output of MySQL:

mysql> show create table v_test; +--------+-------------------------------------------------------------------------------------------------------------------------------------------+----------------------+----------------------+ | View | Create View | character_set_client | collation_connection | +--------+-------------------------------------------------------------------------------------------------------------------------------------------+----------------------+----------------------+ | v_test | CREATE ALGORITHM=UNDEFINED DEFINER=`root`@`localhost` SQL SECURITY DEFINER VIEW `v_test` AS select `t`.`a` AS `a`,`t`.`b` AS `b` from `t` | utf8 | utf8_general_ci | +--------+-------------------------------------------------------------------------------------------------------------------------------------------+----------------------+----------------------+ 1 row in set (0.00 sec) mysql> show create table t; +-------+------------------------------------------------------------------------------------------------------------------+ | Table | Create Table | +-------+------------------------------------------------------------------------------------------------------------------+ | t | CREATE TABLE `t` ( `a` int(11) DEFAULT NULL, `b` int(11) DEFAULT NULL ) ENGINE=InnoDB DEFAULT CHARSET=latin1 | +-------+------------------------------------------------------------------------------------------------------------------+ 1 row in set (0.00 sec)

seems the number of columns and column names are different between normal table and view.

@AndrewDi Please take a look at this comment.

zz-jason · 2019-01-13T08:03:07Z

@AndrewDi any update?

AndrewDi · 2019-01-13T08:21:05Z

@zz-jason You advise to exact method to fetchShowCreateTable4View?

zz-jason · 2019-01-13T08:23:07Z

@zz-jason You advise to exact method to fetchShowCreateTable4View?

Yes.

executor/show.go

…w/show_create_table

AndrewDi · 2019-01-13T09:10:46Z

/run-all-tests

XuHuaiyu

LGTM

zz-jason · 2019-01-14T12:29:43Z

executor/show.go

 	e.appendRow([]interface{}{tb.Meta().Name.O, buf.String()})
 	return nil
 }

+func (e *ShowExec) fetchShowCreateTable4View(tb *model.TableInfo, buf *bytes.Buffer) {


As @eurekaka mentioned in the earlier code reviews. MySQL behaves different between normal table and view on show create table. For a normal table, the output has two columns, namely Table and Create Table:

MySQL(root@localhost:test) > create table t(a bigint, b bigint); Query OK, 0 rows affected (0.11 sec) MySQL(root@localhost:test) > show create table t; +-------+----------------------------------------------------------------------------------------------------------------------------------------------------+ | Table | Create Table | +-------+----------------------------------------------------------------------------------------------------------------------------------------------------+ | t | CREATE TABLE `t` ( `a` bigint(20) DEFAULT NULL, `b` bigint(20) DEFAULT NULL ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_ai_ci | +-------+----------------------------------------------------------------------------------------------------------------------------------------------------+ 1 row in set (0.01 sec)

But for View, the output contains 4 columns, namely View, Create View, character_set_client and collation_connection:

MySQL(root@localhost:test) > create view v as select * from t; Query OK, 0 rows affected (0.11 sec) MySQL(root@localhost:test) > show create table v; +------+---------------------------------------------------------------------------------------------------------------------------------------------------------+----------------------+----------------------+ | View | Create View | character_set_client | collation_connection | +------+---------------------------------------------------------------------------------------------------------------------------------------------------------+----------------------+----------------------+ | v | CREATE ALGORITHM=UNDEFINED DEFINER=`skip-grants user`@`skip-grants host` SQL SECURITY DEFINER VIEW `v` AS select `t`.`a` AS `a`,`t`.`b` AS `b` from `t` | utf8mb4 | utf8mb4_0900_ai_ci | +------+---------------------------------------------------------------------------------------------------------------------------------------------------------+----------------------+----------------------+ 1 row in set (0.00 sec)

…w/show_create_table # Conflicts: # executor/show_test.go

zz-jason

LGTM

zz-jason · 2019-01-15T05:17:02Z

/run-all-tests

AndrewDi mentioned this pull request Dec 28, 2018

Tracking view feature implement #8520

Closed

19 tasks

zz-jason added contribution This PR is from a community contributor. sig/execution SIG execution labels Dec 29, 2018

AndrewDi changed the title ~~executor: alter show_create_table to support show view definition [DNM]~~ executor: alter show_create_table to support show view definition Jan 5, 2019

zz-jason changed the title ~~executor: alter show_create_table to support show view definition~~ executor: support "show create table" for View Jan 6, 2019

zz-jason requested review from zz-jason, XuHuaiyu and eurekaka January 6, 2019 07:36

XuHuaiyu reviewed Jan 7, 2019

View reviewed changes

zz-jason reviewed Jan 7, 2019

View reviewed changes

executor/show.go Outdated Show resolved Hide resolved

eurekaka reviewed Jan 7, 2019

View reviewed changes

executor: alter show_create_table to support show view definition

0f7158f

AndrewDi force-pushed the view/show_create_table branch from bdb41af to 0f7158f Compare January 13, 2019 08:23

add test

733ae1e

zz-jason reviewed Jan 13, 2019

View reviewed changes

executor/show.go Show resolved Hide resolved

AndrewDi added 2 commits January 13, 2019 16:51

fix ci

8a4ceeb

fix ci

01528b9

zz-jason reviewed Jan 13, 2019

View reviewed changes

executor/show.go Outdated Show resolved Hide resolved

AndrewDi and others added 4 commits January 13, 2019 16:53

fix ci

edaaa27

fix sqlmode=nil

9799089

Merge branch 'master' into view/show_create_table

3bcdd87

fix sqlmode=nil

be1341a

AndrewDi added 3 commits January 13, 2019 16:58

Merge remote-tracking branch 'origin/view/show_create_table' into vie…

4ed4dda

…w/show_create_table

fix sqlmode=nil

64aa696

fix sqlmode=nil

3c2b07d

XuHuaiyu requested review from eurekaka and zz-jason January 14, 2019 12:23

XuHuaiyu reviewed Jan 14, 2019

View reviewed changes

zz-jason reviewed Jan 14, 2019

View reviewed changes

AndrewDi and others added 7 commits January 15, 2019 11:39

Port mysql output format

da87f19

Port mysql output format

d5cbffa

Merge branch 'master' into view/show_create_table

5a6f0a1

fix ci

4bfb9d4

fix ci

39acbcc

Merge remote-tracking branch 'origin/view/show_create_table' into vie…

a6b86dc

…w/show_create_table # Conflicts: # executor/show_test.go

fix ci

7e6eff5

zz-jason approved these changes Jan 15, 2019

View reviewed changes

zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 15, 2019

zz-jason merged commit e6a0eb9 into pingcap:master Jan 15, 2019

zz-jason added the status/all tests passed label Jan 15, 2019

AndrewDi deleted the view/show_create_table branch January 15, 2019 09:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

executor: support "show create table" for View #8865

executor: support "show create table" for View #8865

AndrewDi commented Dec 28, 2018 •

edited by c4pt0r

Loading

zz-jason commented Jan 5, 2019

AndrewDi commented Jan 5, 2019

codecov-io commented Jan 5, 2019 •

edited

Loading

XuHuaiyu left a comment

zz-jason commented Jan 7, 2019

eurekaka Jan 7, 2019

zz-jason Jan 13, 2019

zz-jason commented Jan 13, 2019

AndrewDi commented Jan 13, 2019

zz-jason commented Jan 13, 2019

AndrewDi commented Jan 13, 2019

XuHuaiyu left a comment

zz-jason Jan 14, 2019

AndrewDi Jan 15, 2019

zz-jason left a comment

zz-jason commented Jan 15, 2019

executor: support "show create table" for View #8865

executor: support "show create table" for View #8865

Conversation

AndrewDi commented Dec 28, 2018 • edited by c4pt0r Loading

What problem does this PR solve?

What is changed and how it works?

Check List

zz-jason commented Jan 5, 2019

AndrewDi commented Jan 5, 2019

codecov-io commented Jan 5, 2019 • edited Loading

Codecov Report

XuHuaiyu left a comment

Choose a reason for hiding this comment

zz-jason commented Jan 7, 2019

eurekaka Jan 7, 2019

Choose a reason for hiding this comment

zz-jason Jan 13, 2019

Choose a reason for hiding this comment

zz-jason commented Jan 13, 2019

AndrewDi commented Jan 13, 2019

zz-jason commented Jan 13, 2019

AndrewDi commented Jan 13, 2019

XuHuaiyu left a comment

Choose a reason for hiding this comment

zz-jason Jan 14, 2019

Choose a reason for hiding this comment

AndrewDi Jan 15, 2019

Choose a reason for hiding this comment

zz-jason left a comment

Choose a reason for hiding this comment

zz-jason commented Jan 15, 2019

AndrewDi commented Dec 28, 2018 •

edited by c4pt0r

Loading

codecov-io commented Jan 5, 2019 •

edited

Loading