Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: fix subquery hint panic #8781

Merged
merged 3 commits into from
Dec 25, 2018
Merged

parser: fix subquery hint panic #8781

merged 3 commits into from
Dec 25, 2018

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Dec 24, 2018 •
edited by c4pt0r
Loading

What problem does this PR solve?

ref pingcap/parser#120, fix subquery hint problem

What is changed and how it works?

In parser, just reset $ to nil to protect reuse old memory with other value

here just refer pingcap/parser#120 change

Check List

Tests

  • old test case and parser's unit test

Code changes

Side effects

  • N/A

Related changes

  • Need to cherry-pick to the release branch

This change is Reviewable

@lysu lysu added type/bugfix This PR fixes a bug. component/parser labels Dec 24, 2018
@lysu
Copy link
Contributor Author

lysu commented Dec 24, 2018

/run-all-tests

@shenli
Copy link
Member

shenli commented Dec 24, 2018

Please fix the CI.

@lysu
Copy link
Contributor Author

lysu commented Dec 25, 2018

/run-all-tests

@lysu lysu mentioned this pull request Dec 25, 2018
Merged
@lysu
Copy link
Contributor Author

lysu commented Dec 25, 2018

/run-integration-common-test

@lysu lysu requested review from zz-jason and jackysp December 25, 2018 05:26
zimulala
zimulala reviewed Dec 25, 2018
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 25, 2018
jackysp
jackysp approved these changes Dec 25, 2018
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp merged commit c385cbd into pingcap:master Dec 25, 2018
zz-jason pushed a commit that referenced this pull request Dec 28, 2018
@lysu @zz-jason
parser: fix subquery hint panic (#8781) (#8800)
16b327f
yu34po pushed a commit to yu34po/tidb that referenced this pull request Jan 2, 2019
@lysu @yu34po
parser: fix subquery hint panic (pingcap#8781)
e77c501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@jackysp jackysp jackysp approved these changes

@zz-jason zz-jason Awaiting requested review from zz-jason

Assignees
No one assigned
Labels
component/parser status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lysu @shenli @zimulala @jackysp