planner: fix error caused by different length between inner and outer OrderByItems #8273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zz-jason
added
contribution
eurekaka
reviewed
Nov 12, 2018
|
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
|
/run-all-tests |
|
It will be nice if you can add the case mentioned in the issue as an integration test. |
Ok I will add it. |
|
/run-all-tests |
|
@mtunique Could you please cherry-pick this PR to the release-2.1 and release-2.0 branch after it merged? |
OK |
XuHuaiyu
changed the title
|
/run-all-tests |
Done. Add two explain cases. |
|
LGTM |
lzmhhh123
added
status/LGT2
zz-jason
approved these changes
Nov 13, 2018
mtunique
added a commit
to mtunique/tidb
that referenced
this pull request
Nov 13, 2018
zz-jason
pushed a commit
that referenced
this pull request
Nov 14, 2018
mtunique
added a commit
to mtunique/tidb
that referenced
this pull request
Nov 14, 2018
zz-jason
pushed a commit
that referenced
this pull request
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #8198 nest different size order by.
What is changed and how it works?
matchItemsfunction cannot cover the case that the length of columns is greater than items.Check the length before iterating the columns.
Check List
Tests
Related changes