-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: refine built-in func truncate to support uint arg (#8000) #8069
Conversation
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
@yu34po Please fill the pr description. |
@yu34po |
/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0 |
1 similar comment
/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0 |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
fix #7591
fix #7615
What is changed and how it works?
1.add an builtinTruncateUintSig Function to support unsigned int truncate
2.change builtinTruncateIntSig truncate function to avoid get incorrect value
Check List
Tests
Code changes
Side effects
Related changes