Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: maintain DeferredExpr in aggressive constant folding. #7926

Merged
merged 2 commits into from
Oct 18, 2018

Conversation

eurekaka
Copy link
Contributor

What problem does this PR solve?

Cherry-picked from #7915

What is changed and how it works?

Store DeferredExpr in folded constant for ScalarFunction according to whether its arguments are deferred;

Check List

Tests

  • Unit test

Side effects

N/A

Related changes

N/A

@eurekaka eurekaka added type/bugfix This PR fixes a bug. sig/planner SIG: Planner type/2.1 cherry-pick component/expression and removed sig/planner SIG: Planner labels Oct 17, 2018
@eurekaka
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka
Copy link
Contributor Author

@zz-jason PTAL

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 18, 2018
@zz-jason
Copy link
Member

/run-all-tests

@zz-jason zz-jason merged commit 3e3b905 into pingcap:release-2.1 Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants