Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: add comment for #7252 #7549

Merged
merged 3 commits into from
Aug 30, 2018
Merged

server: add comment for #7252 #7549

merged 3 commits into from
Aug 30, 2018

Conversation

imtbkcat
Copy link

What problem does this PR solve?

Add comment for #7525 to make code readable.

What is changed and how it works?

Add comment.

Check List

Tests

  • Unit test

Code changes

  • No change

Side effects

  • No

@imtbkcat imtbkcat requested review from jackysp and zhexuany August 30, 2018 04:21
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 30, 2018
@jackysp jackysp merged commit f915575 into pingcap:master Aug 30, 2018
@imtbkcat imtbkcat deleted the addcomment branch August 30, 2018 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants