-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: add batch copy to inner join, left and right outer join. #7493
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
0cc4ab9
batch copy init
crazycs520 2592034
add comment
crazycs520 265dd58
add batch copy test and benchmark
crazycs520 39cde9c
refine code
crazycs520 7b19c1c
fix bugs
crazycs520 e312fa4
Merge branch 'master' of https://github.com/pingcap/tidb into only-ba…
crazycs520 4022038
Merge branch 'master' of https://github.com/pingcap/tidb into only-ba…
crazycs520 9b6ce0f
Merge branch 'master' of https://github.com/pingcap/tidb into only-ba…
crazycs520 315c1fa
refactor code and comment
crazycs520 37902a2
refine code
crazycs520 c4556b4
address comment
crazycs520 cefae06
refactor code and comment
crazycs520 9fe55b3
refactor code and comment
crazycs520 91366cd
address comment
crazycs520 d3f8e85
address comment
crazycs520 026be7f
Merge branch 'master' of https://github.com/pingcap/tidb into only-ba…
crazycs520 50a698d
address comment
crazycs520 28018f9
address comment
crazycs520 2d04676
Merge branch 'master' into only-batch-copy
zz-jason e47fb7c
Merge branch 'master' into only-batch-copy
zz-jason 3208738
refine comments
crazycs520 cd6eda1
Merge branch 'master' of https://github.com/pingcap/tidb into only-ba…
crazycs520 cedcd0e
Merge branch 'only-batch-copy' of https://github.com/crazycs520/tidb …
crazycs520 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,107 @@ | ||
// Copyright 2018 PingCAP, Inc. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package chunk | ||
|
||
// CopySelectedJoinRows copies the selected joined rows from the source Chunk | ||
// to the destination Chunk. | ||
// Return true if at least one joined row was selected. | ||
// | ||
// NOTE: All the outer rows in the source Chunk should be the same. | ||
func CopySelectedJoinRows(src *Chunk, innerColOffset, outerColOffset int, selected []bool, dst *Chunk) bool { | ||
if src.NumRows() == 0 { | ||
return false | ||
} | ||
|
||
numSelected := copySelectedInnerRows(innerColOffset, outerColOffset, src, selected, dst) | ||
copyOuterRows(innerColOffset, outerColOffset, src, numSelected, dst) | ||
dst.numVirtualRows += numSelected | ||
return numSelected > 0 | ||
} | ||
|
||
// copySelectedInnerRows copies the selected inner rows from the source Chunk | ||
// to the destination Chunk. | ||
// return the number of rows which is selected. | ||
func copySelectedInnerRows(innerColOffset, outerColOffset int, src *Chunk, selected []bool, dst *Chunk) int { | ||
oldLen := dst.columns[innerColOffset].length | ||
var srcCols []*column | ||
if innerColOffset == 0 { | ||
srcCols = src.columns[:outerColOffset] | ||
} else { | ||
srcCols = src.columns[innerColOffset:] | ||
} | ||
for j, srcCol := range srcCols { | ||
dstCol := dst.columns[innerColOffset+j] | ||
if srcCol.isFixed() { | ||
for i := 0; i < len(selected); i++ { | ||
if !selected[i] { | ||
continue | ||
} | ||
dstCol.appendNullBitmap(!srcCol.isNull(i)) | ||
dstCol.length++ | ||
|
||
elemLen := len(srcCol.elemBuf) | ||
offset := i * elemLen | ||
dstCol.data = append(dstCol.data, srcCol.data[offset:offset+elemLen]...) | ||
} | ||
} else { | ||
for i := 0; i < len(selected); i++ { | ||
if !selected[i] { | ||
continue | ||
} | ||
dstCol.appendNullBitmap(!srcCol.isNull(i)) | ||
dstCol.length++ | ||
|
||
start, end := srcCol.offsets[i], srcCol.offsets[i+1] | ||
dstCol.data = append(dstCol.data, srcCol.data[start:end]...) | ||
dstCol.offsets = append(dstCol.offsets, int32(len(dstCol.data))) | ||
} | ||
} | ||
} | ||
return dst.columns[innerColOffset].length - oldLen | ||
} | ||
|
||
// copyOuterRows copies the continuous 'numRows' outer rows in the source Chunk | ||
// to the destination Chunk. | ||
func copyOuterRows(innerColOffset, outerColOffset int, src *Chunk, numRows int, dst *Chunk) { | ||
if numRows <= 0 { | ||
return | ||
} | ||
row := src.GetRow(0) | ||
var srcCols []*column | ||
if innerColOffset == 0 { | ||
srcCols = src.columns[outerColOffset:] | ||
} else { | ||
srcCols = src.columns[:innerColOffset] | ||
} | ||
for i, srcCol := range srcCols { | ||
dstCol := dst.columns[outerColOffset+i] | ||
dstCol.appendMultiSameNullBitmap(!srcCol.isNull(row.idx), numRows) | ||
dstCol.length += numRows | ||
if srcCol.isFixed() { | ||
elemLen := len(srcCol.elemBuf) | ||
start := row.idx * elemLen | ||
end := start + numRows*elemLen | ||
dstCol.data = append(dstCol.data, srcCol.data[start:end]...) | ||
} else { | ||
start, end := srcCol.offsets[row.idx], srcCol.offsets[row.idx+numRows] | ||
dstCol.data = append(dstCol.data, srcCol.data[start:end]...) | ||
offsets := dstCol.offsets | ||
elemLen := srcCol.offsets[row.idx+1] - srcCol.offsets[row.idx] | ||
for j := 0; j < numRows; j++ { | ||
offsets = append(offsets, int32(offsets[len(offsets)-1]+elemLen)) | ||
} | ||
dstCol.offsets = offsets | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,83 @@ | ||
// Copyright 2018 PingCAP, Inc. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package chunk | ||
|
||
import ( | ||
"reflect" | ||
"testing" | ||
|
||
"github.com/pingcap/tidb/types" | ||
) | ||
|
||
func getChk() (*Chunk, *Chunk, []bool) { | ||
numRows := 1024 | ||
srcChk := newChunkWithInitCap(numRows, 0, 0, 8, 8, 16, 0) | ||
selected := make([]bool, numRows) | ||
var row Row | ||
for j := 0; j < numRows; j++ { | ||
if j%7 == 0 { | ||
row = MutRowFromValues("abc", "abcdefg", nil, 123, types.ZeroDatetime, "abcdefg").ToRow() | ||
} else { | ||
row = MutRowFromValues("abc", "abcdefg", j, 123, types.ZeroDatetime, "abcdefg").ToRow() | ||
selected[j] = true | ||
} | ||
srcChk.AppendPartialRow(0, row) | ||
} | ||
dstChk := newChunkWithInitCap(numRows, 0, 0, 8, 8, 16, 0) | ||
return srcChk, dstChk, selected | ||
} | ||
|
||
func TestCopySelectedJoinRows(t *testing.T) { | ||
srcChk, dstChk, selected := getChk() | ||
numRows := srcChk.NumRows() | ||
for i := 0; i < numRows; i++ { | ||
if !selected[i] { | ||
continue | ||
} | ||
dstChk.AppendRow(srcChk.GetRow(i)) | ||
} | ||
// batch copy | ||
dstChk2 := newChunkWithInitCap(numRows, 0, 0, 8, 8, 16, 0) | ||
CopySelectedJoinRows(srcChk, 0, 3, selected, dstChk2) | ||
|
||
if !reflect.DeepEqual(dstChk, dstChk2) { | ||
t.Fatal() | ||
} | ||
} | ||
|
||
func BenchmarkCopySelectedJoinRows(b *testing.B) { | ||
b.ReportAllocs() | ||
srcChk, dstChk, selected := getChk() | ||
b.ResetTimer() | ||
for i := 0; i < b.N; i++ { | ||
dstChk.Reset() | ||
CopySelectedJoinRows(srcChk, 0, 3, selected, dstChk) | ||
} | ||
} | ||
|
||
func BenchmarkAppendSelectedRow(b *testing.B) { | ||
b.ReportAllocs() | ||
srcChk, dstChk, selected := getChk() | ||
numRows := srcChk.NumRows() | ||
b.ResetTimer() | ||
for i := 0; i < b.N; i++ { | ||
dstChk.Reset() | ||
for j := 0; j < numRows; j++ { | ||
if !selected[j] { | ||
continue | ||
} | ||
dstChk.AppendRow(srcChk.GetRow(j)) | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it be possible that
row.Idx+1
out of range?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the normal case, it will not out of range.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it be possible that
src.NumRows
equals 1, if so, it seems this will be out of range? @crazycs520There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if
src.NumRows
equals 1, the lengh ofoffsets
should be 2.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok