-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util/charset: Add utf8mb4 as alias for utf8 #7339
Conversation
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
@morgo Please add a test case for this PR. |
/run-all-tests |
/run-unit-test |
Supports applications which directly change to utf8mb4 charset. Safe for TiDB to treat both as the same. Fixes #7267
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Supports applications which directly change to utf8mb4 charset.
Safe for TiDB to treat both as the same.
Fixes #7267
What have you changed? (mandatory)
Added an alias for utf8mb4 as a character set. It is treated the same as utf8.
What is the type of the changes? (mandatory)
Bug fix/compatibility improvement.
How has this PR been tested? (mandatory)
Manual testing:
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
No
Does this PR affect tidb-ansible update? (mandatory)
No
Does this PR need to be added to the release notes? (mandatory)
Refer to a related PR or issue link (optional)
Fixes #7267
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)