Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics,server: add a get_token_duration_seconds metrics #7110

Merged
merged 8 commits into from
Jul 23, 2018
Merged

metrics,server: add a get_token_duration_seconds metrics #7110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
37f24be
metrics,server: add a get_token_duration_seconds metrics
tiancaiamao Jul 19, 2018
f6cdf20
Merge branch 'master' into get-token-metrics
shenli Jul 19, 2018
1cab197
Merge branch 'master' into get-token-metrics
zz-jason Jul 20, 2018
ca395ae
address comment
tiancaiamao Jul 23, 2018
78d07f9
Merge branch 'get-token-metrics' of github.com:tiancaiamao/tidb into …
tiancaiamao Jul 23, 2018
650bf61
address comment
tiancaiamao Jul 23, 2018
80c4502
fix ci
tiancaiamao Jul 23, 2018
a5ee16f
Merge branch 'master' into get-token-metrics
tiancaiamao Jul 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions metrics/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,15 @@ var (
Help: "Counter of hand shake error.",
},
)

GetTokenDurationHistogram = prometheus.NewHistogram(
prometheus.HistogramOpts{
Namespace: "tidb",
Subsystem: "server",
Name: "get_token_duration_seconds",
Help: "Duration (us) for getting token, it should be small until concurrency limit is reached.",
Buckets: prometheus.ExponentialBuckets(1, 2, 22), // 1us ~ 2s
})
)

func init() {
Expand All @@ -124,6 +133,7 @@ func init() {
prometheus.MustRegister(KeepAliveCounter)
prometheus.MustRegister(PlanCacheCounter)
prometheus.MustRegister(HandShakeErrorCounter)
prometheus.MustRegister(GetTokenDurationHistogram)
}

// ExecuteErrorToLabel converts an execute error to label.
Expand Down
6 changes: 5 additions & 1 deletion server/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,11 @@ func (s *Server) ConnectionCount() int {
}

func (s *Server) getToken() *Token {
return s.concurrentLimiter.Get()
start := time.Now()
tok := s.concurrentLimiter.Get()
// Note that data smaller than one microsecond is ignored, because that case can be viewed as non-block.
metrics.GetTokenDurationHistogram.Observe(float64(time.Since(start).Nanoseconds() / 1e3))
return tok
}

func (s *Server) releaseToken(token *Token) {
Expand Down