plan: always chose the smaller child as outer for IndexJoin

plan/gen_physical_plans.go

@@ -385,22 +385,30 @@ func (p *LogicalJoin) tryToGetIndexJoin(prop *requiredProp) ([]PhysicalPlan, boo
 			plans = append(plans, join...)
 		}
 	case InnerJoin:
-		join := p.getIndexJoinByOuterIdx(prop, 0)
-		if join != nil {
+		lhsCardinality := p.Children()[0].cardinality()
+		rhsCardinality := p.Children()[1].cardinality()
+
+		leftJoins := p.getIndexJoinByOuterIdx(prop, 0)
+		if leftOuter && leftJoins != nil {
 			// If the plan is not nil and matches the hint, return it directly.
-			if leftOuter {
-				return join, true
-			}
-			plans = append(plans, join...)
+			return leftJoins, true
 		}
-		join = p.getIndexJoinByOuterIdx(prop, 1)
-		if join != nil {
+
+		rightJoins := p.getIndexJoinByOuterIdx(prop, 1)
+		if rightOuter && rightJoins != nil {
 			// If the plan is not nil and matches the hint, return it directly.
-			if rightOuter {
-				return join, true
-			}
-			plans = append(plans, join...)
+			return rightJoins, true
 		}
+
+		if leftJoins != nil && lhsCardinality < rhsCardinality {
+			return leftJoins, leftOuter
+		}
+		if rightJoins != nil && rhsCardinality < lhsCardinality {
+			return rightJoins, rightOuter
+		}
+
+		plans = append(plans, leftJoins...)
+		plans = append(plans, rightJoins...)
 	}
 	return plans, false
 }

plan/plan.go

@@ -15,6 +15,7 @@ package plan
 
 import (
 	"fmt"
+	"math"
 
 	"github.com/juju/errors"
 	"github.com/pingcap/tidb/ast"
@@ -163,6 +164,8 @@ type LogicalPlan interface {
 	// deriveStats derives statistic info between plans.
 	deriveStats() (*statsInfo, error)
 
+	cardinality() float64
+
 	// preparePossibleProperties is only used for join and aggregation. Like group by a,b,c, all permutation of (a,b,c) is
 	// valid, but the ordered indices in leaf plan is limited. So we can get all possible order properties by a pre-walking.
 	// Please make sure that children's method is called though we may not need its return value,
@@ -320,6 +323,20 @@ type basePlan struct {
 	stats *statsInfo
 }
 
+func (p *DataSource) cardinality() float64 {
+	if p.statsAfterSelect == nil {
+		return math.MaxFloat64
+	}
+	return p.statsAfterSelect.count
+}
+
+func (p *basePlan) cardinality() float64 {
+	if p.stats == nil {
+		return math.MaxFloat64
+	}
+	return p.stats.count
+}
+
 func (p *basePlan) replaceExprColumns(replace map[string]*expression.Column) {
 }