*: return error instead of log.Fatal for TableFromMeta #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
1 similar comment
|
LGTM |
qiuyesuifeng
added a commit
that referenced
this pull request
Dec 9, 2015
*: return error instead of log.Fatal for TableFromMeta
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
* stats: disable stats by default * add test for disable stats * set statsLease to -1 in restore
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Sep 28, 2021
* terror: replace sirupsen/logrus by pingcap/log also fixed test failure on Windows * circle.yml: restrict test parallelism in integration tests also, stop verifying parser.go and code format in the integration tests... those steps are redundant. * codecov: add codecov.yml, based on pingcap#9618 Co-authored-by: tiancaiamao <[email protected]>
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Oct 8, 2021
* terror: replace sirupsen/logrus by pingcap/log also fixed test failure on Windows * circle.yml: restrict test parallelism in integration tests also, stop verifying parser.go and code format in the integration tests... those steps are redundant. * codecov: add codecov.yml, based on pingcap#9618 Co-authored-by: tiancaiamao <[email protected]>
ti-chi-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
* terror: replace sirupsen/logrus by pingcap/log also fixed test failure on Windows * circle.yml: restrict test parallelism in integration tests also, stop verifying parser.go and code format in the integration tests... those steps are redundant. * codecov: add codecov.yml, based on #9618 Co-authored-by: tiancaiamao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@qiuyesuifeng @disksing