*: 'load data' should not use latches #6927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'load data' is not retryable when it meets conflicts, while latches may result in false positive transaction conflicts. so enable latches will lead to 'load data' abort abnormally, even there are no conflicts.
coocood
reviewed
Jun 28, 2018
store/tikv/txn.go
Outdated
| forUpdate = option.(bool) | ||
| var bypassLatch bool | ||
| if option := txn.us.GetOption(kv.BypassLatch); option != nil { | ||
| bypassLatch = option.(bool) | ||
| } | ||
| // For update transaction is not retryable, commit directly. |
There was a problem hiding this comment.
Need to update the comment too.
coocood
reviewed
Jun 28, 2018
| "github.com/pingcap/tidb/table" | ||
| "github.com/pingcap/tidb/types" | ||
| "github.com/pingcap/tidb/util/testkit" | ||
| ) | ||
|
|
||
| type testBypassSuite struct{} |
There was a problem hiding this comment.
This test create a new store to set latch capacity, it's not common in testSuite.
And if I write it in testSuite, I found TestShow fail:
FAIL: show_test.go:35: testSuite.TestShow
show_test.go:141:
result = tk.MustQuery(testSQL)
/media/genius/OS/project/src/github.com/pingcap/tidb/util/testkit/testkit.go:180:
tk.c.Assert(errors.ErrorStack(err), check.Equals, "", comment)
... obtained string = "" +
... "/media/genius/OS/project/src/github.com/pingcap/tidb/store/tikv/snapshot.go:312: tikv aborts txn: leveldb: closed\n" +
... "/media/genius/OS/project/src/github.com/pingcap/tidb/store/tikv/snapshot.go:314: \n" +
... "/media/genius/OS/project/src/github.com/pingcap/tidb/store/tikv/snapshot.go:269: \n" +
... "/media/genius/OS/project/src/github.com/pingcap/tidb/store/tikv/snapshot.go:218: \n" +
... "/media/genius/OS/project/src/github.com/pingcap/tidb/kv/union_store.go:186: \n" +
... "/media/genius/OS/project/src/github.com/pingcap/tidb/store/tikv/txn.go:96: \n" +
... "/media/genius/OS/project/src/github.com/pingcap/tidb/structure/list.go:220: \n" +
... "/media/genius/OS/project/src/github.com/pingcap/tidb/structure/list.go:164: \n" +
... "/media/genius/OS/project/src/github.com/pingcap/tidb/meta/meta.go:499: \n" +
... "/media/genius/OS/project/src/github.com/pingcap/tidb/meta/meta.go:512: \n" +
... "/media/genius/OS/project/src/github.com/pingcap/tidb/util/admin/admin.go:52: \n" +
... "/media/genius/OS/project/src/github.com/pingcap/tidb/ddl/stat.go:58: \n" +
... "/media/genius/OS/project/src/github.com/pingcap/tidb/kv/txn.go:57: \n" +
So I just create a new Suite.
|
LGTM |
|
PTAL @zhexuany |
|
PTAL @jackysp |
|
@tiancaiamao Please resolve conflict. |
coocood
approved these changes
Jul 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
'load data' is not retryable when it meets conflicts, while latches may result in
false positive transaction conflicts. so enable latches will lead to 'load data'
abort abnormally, even there are no conflicts.
What are the type of the changes (mandatory)?
How has this PR been tested (mandatory)?
Refer to a related PR or issue link (optional)
#6418
@coocood @AndreMouche @shenli