mocktikv: tiny update ScanLock and ResolveLock function #6275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the semantics more clear for MVCCStore, it handles raw key (tableID + PK) it encode the key to MvccKey in the storage layer.
zhexuany
reviewed
Apr 13, 2018
| @@ -800,10 +800,6 @@ func (mvcc *MVCCLevelDB) ResolveLock(startKey, endKey []byte, startTS, commitTS | |||
| mvcc.mu.Lock() | |||
| defer mvcc.mu.Unlock() | |||
|
|
|||
| // startKey and endKey are MvccKey type actually, take out the raw key here. | |||
There was a problem hiding this comment.
why do you remove both startKey and endKey? They will be used later.
There was a problem hiding this comment.
I don't remove it, just move the code here:
https://github.com/pingcap/tidb/pull/6275/files#diff-fe4f53947ee477517e64d4c2b1408e98R329
|
/run-all-tests |
|
LGTM. |
|
PTAL @MyonKeminta @coocood |
zhexuany
approved these changes
Apr 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the semantics more clear for MVCCStore, it handles raw key (tableID + PK)
it encode the key to MvccKey in the storage layer.
@disksing @MyonKeminta