Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variable: fix NewSessionVars #6272

Merged
merged 1 commit into from
Apr 11, 2018
Merged

Conversation

coocood
Copy link
Member

@coocood coocood commented Apr 11, 2018

Set IndexLookupJoinConcurrency to the default value.
If this value is inited as 0, index lookup join will hang forever.

This issue occurs when we upgrade tidb-server on an existing cluster, the old cluster doesn't have global variable index_lookup_join_concurrency, so the 0 value is not overwritten to 4.

Set IndexLookupJoinConcurrency to default value.
If this value is init as 0, index lookup join will hang forever.
@coocood coocood added type/bugfix This PR fixes a bug. priority/P1 The issue has P1 priority. labels Apr 11, 2018
@coocood
Copy link
Member Author

coocood commented Apr 11, 2018

@zz-jason @shenli @zimulala PTAL

@zz-jason
Copy link
Member

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 11, 2018
@coocood
Copy link
Member Author

coocood commented Apr 11, 2018

/run-all-tests

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood coocood merged commit dd98c70 into pingcap:master Apr 11, 2018
@coocood coocood deleted the fix-init-session-vars branch April 11, 2018 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/P1 The issue has P1 priority. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants