Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: remove Next function of IndexReaderExecutor #6165

Merged
merged 10 commits into from
Mar 30, 2018
Merged

executor: remove Next function of IndexReaderExecutor #6165

merged 10 commits into from
Mar 30, 2018

Conversation

CocaLi
Copy link
Contributor

@CocaLi CocaLi commented Mar 27, 2018

No description provided.

@sre-bot
Copy link
Contributor

sre-bot commented Mar 27, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@CLAassistant
Copy link

CLAassistant commented Mar 27, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@shenli
Copy link
Member

shenli commented Mar 27, 2018

@CocaLi Thanks!
Please fix the CI and sign the CLA.

@shenli shenli added the contribution This PR is from a community contributor. label Mar 27, 2018
@XuHuaiyu
Copy link
Contributor

LGTM

@XuHuaiyu
Copy link
Contributor

/run-all-tests

@XuHuaiyu XuHuaiyu added the DNM label Mar 29, 2018
@XuHuaiyu XuHuaiyu removed the DNM label Mar 30, 2018
@XuHuaiyu XuHuaiyu changed the title executor: delete the obsolete Next() function in IndexLookUpExecutor executor: remove Next function of IndexReaderExecutor Mar 30, 2018
@XuHuaiyu
Copy link
Contributor

LGTM

@XuHuaiyu
Copy link
Contributor

/run-all-tests

@XuHuaiyu XuHuaiyu added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 30, 2018
@XuHuaiyu
Copy link
Contributor

PTAL @zz-jason

@zz-jason
Copy link
Member 

➜ unused github.com/pingcap/tidb/executor
executor/distsql.go:121:6: func decodeRawValues is unused (U1000)
executor/distsql.go:895:31: func (*tableResultHandler).next is unused (U1000)

please remove these unused fields and functions

zz-jason
zz-jason approved these changes Mar 30, 2018
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. all-tests-passed and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 30, 2018
@zz-jason zz-jason merged commit f89f48b into pingcap:master Mar 30, 2018
@XuHuaiyu XuHuaiyu mentioned this pull request Mar 30, 2018
Closed
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CocaLi @sre-bot @CLAassistant @shenli @XuHuaiyu @zz-jason