ddl:support alter table comment #6127
Conversation
|
What is the related github issue? |
model/ddl.go
Outdated
| @@ -45,6 +45,7 @@ const ( | |||
| ActionRenameTable ActionType = 14 | |||
| ActionSetDefaultValue ActionType = 15 | |||
| ActionShardRowID ActionType = 16 | |||
| ActionSetTableComment ActionType = 17 | |||
There was a problem hiding this comment.
s/ActionSetTableComment/ActionModifyTableComment/
ddl/table.go
Outdated
| @@ -335,6 +335,30 @@ func (d *ddl) onRenameTable(t *meta.Meta, job *model.Job) (ver int64, _ error) { | |||
| return ver, nil | |||
| } | |||
|
|
|||
| func (d *ddl) onSetTableComment(t *meta.Meta, job *model.Job) (ver int64, _ error) { | |||
There was a problem hiding this comment.
s/onSetTableComment/onModifyTableComment/
ddl/ddl_api.go
Outdated
| @@ -1436,6 +1439,31 @@ func (d *ddl) AlterColumn(ctx sessionctx.Context, ident ast.Ident, spec *ast.Alt | |||
| return errors.Trace(err) | |||
| } | |||
|
|
|||
| func (d *ddl) TableComment(ctx sessionctx.Context, ident ast.Ident, spec *ast.AlterTableSpec) error { | |||
There was a problem hiding this comment.
s/TableComment/AlterTableComment/
There was a problem hiding this comment.
Please add comments before exported method
ddl/ddl_api.go
Outdated
| TableID: tb.Meta().ID, | ||
| Type: model.ActionSetTableComment, | ||
| BinlogInfo: &model.HistoryInfo{}, | ||
| Args: []interface{}{schema.ID, spec.Name, spec.Comment}, |
There was a problem hiding this comment.
Arg schema.ID is unnecessary, you can use job.SchemaID
ddl/table.go
Outdated
| func (d *ddl) onModifyTableComment(t *meta.Meta, job *model.Job) (ver int64, _ error) { | ||
| var tableName string | ||
| var comment string | ||
| if err := job.DecodeArgs(&tableName, &comment); err != nil { |
|
@zimulala PTAL |
ddl/table.go
Outdated
| tblInfo.Comment = comment | ||
| ver, err = updateVersionAndTableInfo(t, job, tblInfo, true) | ||
| if err != nil { | ||
|
|
There was a problem hiding this comment.
Please remove this blank line.
| } | ||
|
|
||
| tb, err := is.TableByName(ident.Schema, ident.Name) | ||
| if err != nil { |
There was a problem hiding this comment.
Please add some tests like TestMySQLErrorCode in ddl_db_test.go
|
@zimulala PTAL |
|
/run-integration-common-test tidb-test=pr/481 |
|
/run-all-tests |
|
/run-all-tests |
ciscoxll
added
status/LGT2
Added a command support alter table comment respond issues #4990
alter table mytable comment 'this is table comment';.