Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove Next() function for MaxOneRowExec #6018

Merged
merged 2 commits into from
Mar 12, 2018
Merged

remove Next() function for MaxOneRowExec #6018

merged 2 commits into from
Mar 12, 2018

Conversation

qxhy123
Copy link
Contributor

@qxhy123 qxhy123 commented Mar 12, 2018

No description provided.

@sre-bot
Copy link
Contributor

sre-bot commented Mar 12, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

winkyao
winkyao reviewed Mar 12, 2018
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao winkyao added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 12, 2018
XuHuaiyu
XuHuaiyu approved these changes Mar 12, 2018
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu
Copy link
Contributor

/run-all-tests

@XuHuaiyu XuHuaiyu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 12, 2018
@zz-jason zz-jason added the contribution This PR is from a community contributor. label Mar 12, 2018
@XuHuaiyu XuHuaiyu mentioned this pull request Mar 12, 2018
Closed
41 tasks
@zz-jason zz-jason merged commit cfab51b into pingcap:master Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winkyao winkyao winkyao left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qxhy123 @sre-bot @XuHuaiyu @winkyao @zz-jason