Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: upgrade go1.23.7 #59903

Merged
merged 1 commit into from
Mar 5, 2025
Merged

*: upgrade go1.23.7 #59903

merged 1 commit into from
Mar 5, 2025

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Mar 5, 2025

What problem does this PR solve?

Issue Number: close #59905

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/dumpling This is related to Dumpling of TiDB. and removed do-not-merge/needs-tests-checked labels Mar 5, 2025
@hawkingrei hawkingrei added skip-issue-check Indicates that a PR no need to check linked issue. do-not-merge/needs-tests-checked labels Mar 5, 2025
@hawkingrei hawkingrei requested review from lance6716 and xhebox and removed request for lance6716 March 5, 2025 04:00
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 5, 2025
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.3650%. Comparing base (a6094f7) to head (913484d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59903        +/-   ##
================================================
+ Coverage   72.9269%   73.3650%   +0.4380%     
================================================
  Files          1700       1700                
  Lines        469718     469758        +40     
================================================
+ Hits         342551     344638      +2087     
+ Misses       106052     104027      -2025     
+ Partials      21115      21093        -22     
Flag Coverage Δ
integration 42.7779% <ø> (?)
unit 72.1582% <ø> (+0.0298%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 44.9003% <ø> (+0.0167%) ⬆️

Copy link

ti-chi-bot bot commented Mar 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 5, 2025
Copy link

ti-chi-bot bot commented Mar 5, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-05 04:08:38.161497124 +0000 UTC m=+414631.290416866: ☑️ agreed by xhebox.
  • 2025-03-05 04:49:16.002472955 +0000 UTC m=+417069.131392698: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit b0efc0f into pingcap:master Mar 5, 2025
29 checks passed
@hawkingrei hawkingrei deleted the go1237 branch March 5, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component/dumpling This is related to Dumpling of TiDB. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade go.1.237
3 participants