Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log restore: fix the bottleneck of btree map #59896

Merged
merged 3 commits into from
Mar 5, 2025

Conversation

3pointer
Copy link
Contributor

@3pointer 3pointer commented Mar 4, 2025

What problem does this PR solve?

Issue Number: close #59900

Problem Summary:
The current log restore process accumulates small files, which can negatively impact performance. During performance testing, log restore took twice as long as before due to the excessive number of small files. To optimize performance, we should skip accumulating small files, as was done previously.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

before this PR
image

after this PR
image

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

ti-chi-bot bot commented Mar 4, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 4, 2025
Copy link

tiprow bot commented Mar 4, 2025

Hi @3pointer. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@3pointer 3pointer marked this pull request as ready for review March 5, 2025 03:52
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 5, 2025
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.7004%. Comparing base (b500d9e) to head (cd9dc1f).
Report is 9 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59896        +/-   ##
================================================
+ Coverage   72.9585%   74.7004%   +1.7418%     
================================================
  Files          1700       1717        +17     
  Lines        469738     470992      +1254     
================================================
+ Hits         342714     351833      +9119     
+ Misses       105904      97312      -8592     
- Partials      21120      21847       +727     
Flag Coverage Δ
integration 46.2401% <100.0000%> (?)
unit 72.2577% <100.0000%> (+0.0807%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 61.7466% <100.0000%> (+16.8630%) ⬆️

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 5, 2025
Copy link

ti-chi-bot bot commented Mar 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 5, 2025
Copy link

ti-chi-bot bot commented Mar 5, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-05 04:41:43.085352089 +0000 UTC m=+416616.214271834: ☑️ agreed by Leavrth.
  • 2025-03-05 06:51:21.251945017 +0000 UTC m=+424394.380864761: ☑️ agreed by YuJuncen.

@3pointer
Copy link
Contributor Author

3pointer commented Mar 5, 2025

/rebuild

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit e6b4d95 into pingcap:master Mar 5, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logbackup compaction: There is no optimization effect when the workload data changes are not concentrated
4 participants