Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: preparation for removing Next of Executors #5988

Merged
merged 5 commits into from
Mar 9, 2018
Merged

*: preparation for removing Next of Executors #5988

merged 5 commits into from
Mar 9, 2018

Conversation

XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Mar 9, 2018 •
edited
Loading

This commit

  1. removes EnableChunk
  2. implement Next for baseExecutor and return nil in it.
    PTAL @zz-jason @coocood

@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Mar 9, 2018

/run-all-tests

zz-jason
zz-jason reviewed Mar 9, 2018
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

zz-jason commented Mar 9, 2018

/run-all-tests

@XuHuaiyu XuHuaiyu changed the title *: 1. remove EnableChunk 2. implement Next in baseExecutor to return nil *: preparation for removing Next of Executors Mar 9, 2018
zimulala
zimulala previously approved these changes Mar 9, 2018
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label Mar 9, 2018
@zz-jason
Copy link
Member

zz-jason commented Mar 9, 2018

to #5985

@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Mar 9, 2018

/run-all-tests

zz-jason
zz-jason approved these changes Mar 9, 2018
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Mar 9, 2018

/run-integration-common-test tikv=pr/2809
/run-integration-compatibility-test tikv=pr/2809

@XuHuaiyu XuHuaiyu merged commit a3bf058 into pingcap:master Mar 9, 2018
@XuHuaiyu XuHuaiyu deleted the remove-enable-chunk branch March 9, 2018 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason approved these changes

@zimulala zimulala zimulala left review comments

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XuHuaiyu @zz-jason @zimulala