Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove executor/aggregate.go/HashAggExec #5986

Closed
wants to merge 2 commits into from
Closed

remove executor/aggregate.go/HashAggExec #5986

wants to merge 2 commits into from

Conversation

lwhile
Copy link
Contributor

@lwhile lwhile commented Mar 9, 2018

No description provided.

@sre-bot
Copy link
Contributor

sre-bot commented Mar 9, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@CLAassistant
Copy link

CLAassistant commented Mar 9, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@winoros
Copy link
Member

winoros commented Mar 9, 2018

@lwhile Are you dealing with #5985 ? We only want to remove the Next() method of it, not the whole HashAggExecutor.

@lwhile
Copy link
Contributor Author

lwhile commented Mar 9, 2018

Sorry, I have fixed it @winoros

@lwhile
Copy link
Contributor Author

lwhile commented Mar 9, 2018

I close this PR and pull a new one.

@lwhile lwhile closed this Mar 9, 2018
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
contribution This PR is from a community contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lwhile @sre-bot @CLAassistant @winoros