Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix that traffic replay from S3 always report an error #59813

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

djshow832
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #59811

Problem Summary:

  • Traffic replay from S3 always reports tiproxy instances number is less than input paths number
  • The URL paths passed to TiProxy miss parameters like access key and endpoint

What changed and how does it work?

  • Extract the right subdirectory from the URL path and then assign it to TiProxy
  • Create another *url.URL object because the previous one is updated in parsing

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Manual test: manually execute traffic replay from S3 and check the result.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 27, 2025
Copy link

tiprow bot commented Feb 27, 2025

Hi @djshow832. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.

Project coverage is 73.4859%. Comparing base (4cf94a7) to head (ea6264d).
Report is 15 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59813        +/-   ##
================================================
+ Coverage   72.9611%   73.4859%   +0.5248%     
================================================
  Files          1697       1699         +2     
  Lines        468962     473297      +4335     
================================================
+ Hits         342160     347807      +5647     
+ Misses       105734     104236      -1498     
- Partials      21068      21254       +186     
Flag Coverage Δ
integration 42.8191% <0.0000%> (?)
unit 72.1781% <76.1904%> (+0.0262%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.0309% <ø> (-0.0854%) ⬇️

@djshow832
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Feb 27, 2025
@djshow832
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 27, 2025
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Feb 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 27, 2025
Copy link

ti-chi-bot bot commented Feb 27, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-27 08:12:32.486752126 +0000 UTC m=+516300.439910392: ☑️ agreed by xhebox.
  • 2025-02-27 08:47:30.190316891 +0000 UTC m=+518398.143475142: ☑️ agreed by YangKeao.

@ti-chi-bot ti-chi-bot bot merged commit 67edd7d into pingcap:master Feb 27, 2025
24 checks passed
@djshow832 djshow832 deleted the fix_store branch February 27, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Traffic replay from S3 always reports error
3 participants