-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: Add failpoint to force pushdown expression to tikv for debug usage #59765
expression: Add failpoint to force pushdown expression to tikv for debug usage #59765
Conversation
Signed-off-by: yibin87 <[email protected]>
Hi @yibin87. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #59765 +/- ##
================================================
+ Coverage 72.9819% 73.8347% +0.8527%
================================================
Files 1698 1699 +1
Lines 469046 472951 +3905
================================================
+ Hits 342319 349202 +6883
+ Misses 105654 102733 -2921
+ Partials 21073 21016 -57
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: windtalker, xzhangxian1008 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: ref #51876
Problem Summary:
To debug expression behaviors not consistent between tidb and tikv, we need to force push down these projection expressions to tikv ignoring cost consideration. So we add a failpoint here to help debug tikv expression behavior.
What changed and how does it work?
Now, after build tidb with failpoint enable: "make failpoint-enable"
export GO_FAILPOINTS="github.com/pingcap/tidb/pkg/expression/forcePushDownTiKV=return(true)"
start tidb server, then a+b and a-b will be pushed down to tikv side:
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.