*: (release-6.5) Validate ts only for stale read #59741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
release-note-none
cfzjywxk
approved these changes
Feb 25, 2025
ti-chi-bot
bot
added
needs-1-more-lgtm
MyonKeminta
approved these changes
Feb 25, 2025
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/retest |
MyonKeminta
added
the
do-not-merge/hold
|
/hold |
ekexium
force-pushed
the
release-6.5-disable-ts-validator
branch
from
91ec14c to
d0bc208
Compare
ekexium
changed the title
Signed-off-by: ekexium <[email protected]>
ekexium
force-pushed
the
release-6.5-disable-ts-validator
branch
from
d0bc208 to
d568bff
Compare
ekexium
changed the title
cfzjywxk
reviewed
Feb 25, 2025
Signed-off-by: ekexium <[email protected]>
ekexium
force-pushed
the
release-6.5-disable-ts-validator
branch
from
12795d4 to
4e8b083
Compare
cfzjywxk
reviewed
Feb 25, 2025
cfzjywxk
approved these changes
Feb 25, 2025
Signed-off-by: ekexium <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #59741 +/- ##
================================================
Coverage ? 73.6550%
================================================
Files ? 1098
Lines ? 353643
Branches ? 0
================================================
Hits ? 260476
Misses ? 76440
Partials ? 16727 |
Signed-off-by: ekexium <[email protected]>
MyonKeminta
approved these changes
Feb 25, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, MyonKeminta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #59402
Problem Summary:
The TS validator has no switch to control. Enabling it by default in an old release version is risky.
What changed and how does it work?
Only enable the ts check for stale reads
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.