br: add log restore ts into snapshot checkpoint metadata #59678

Leavrth · 2025-02-20T09:57:25Z

What problem does this PR solve?

Issue Number: ref #57613

Problem Summary:
The filter feature is determined by the PITR restored ts. If the user specify another restored ts in the second execution, the final filtered tables may be different.

What changed and how does it work?

Add log restored ts into the snapshot restore checkpoint metadata so that BR can promise the same log restored ts before log restore checkpoint metadata is saved.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Jianjun Liao <[email protected]>

tiprow · 2025-02-20T09:57:47Z

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2025-02-20T10:20:05Z

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 75.6609%. Comparing base (42075e6) to head (8fa1d0b).
Report is 48 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #59678        +/-   ##
================================================
+ Coverage   72.9626%   75.6609%   +2.6982%     
================================================
  Files          1694       1716        +22     
  Lines        468752     479415     +10663     
================================================
+ Hits         342014     362730     +20716     
+ Misses       105682      95081     -10601     
- Partials      21056      21604       +548

Flag	Coverage Δ
integration	`47.0947% <50.0000%> (?)`
unit	`73.2756% <0.0000%> (+1.1088%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.6910% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`62.1443% <50.0000%> (+17.0921%)`	⬆️

Tristan1900

thanks for the change!

ti-chi-bot · 2025-02-28T08:27:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, Tristan1900

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~br/OWNERS~~ [BornChanger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2025-02-28T08:28:00Z

[LGTM Timeline notifier]

Timeline:

2025-02-25 04:39:49.300888053 +0000 UTC m=+330737.254046318: ☑️ agreed by Tristan1900.
2025-02-28 08:27:59.432666795 +0000 UTC m=+603627.385825058: ☑️ agreed by BornChanger.

BornChanger · 2025-02-28T09:07:37Z

/test tidb_parser_test

ti-chi-bot · 2025-02-28T09:07:40Z

@BornChanger: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build

/test check-dev

/test check-dev2

/test mysql-test

/test pull-br-integration-test

/test pull-integration-ddl-test

/test pull-integration-e2e-test

/test pull-lightning-integration-test

/test pull-mysql-client-test

/test pull-unit-test-ddlv1

/test unit-test

The following commands are available to trigger optional jobs:

/test pingcap/tidb/canary_ghpr_unit_test

/test pull-common-test

/test pull-e2e-test

/test pull-integration-common-test

/test pull-integration-copr-test

/test pull-integration-jdbc-test

/test pull-integration-mysql-test

/test pull-integration-nodejs-test

/test pull-integration-python-orm-test

/test pull-scan-deps

/test pull-sqllogic-test

/test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build

pingcap/tidb/ghpr_check

pingcap/tidb/ghpr_check2

pingcap/tidb/ghpr_mysql_test

pingcap/tidb/ghpr_unit_test

pingcap/tidb/pull_br_integration_test

pingcap/tidb/pull_integration_ddl_test

pingcap/tidb/pull_integration_e2e_test

pingcap/tidb/pull_mysql_client_test

In response to this:

/test tidb_parser_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2025-02-28T09:08:01Z

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test tidb_parser_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2025-02-28T09:08:02Z

@ti-chi-bot[bot]: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

@BornChanger: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-integration-e2e-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test pull-unit-test-ddlv1
/test unit-test
The following commands are available to trigger optional jobs:
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-integration-python-orm-test
/test pull-scan-deps
/test pull-sqllogic-test
/test pull-tiflash-test
Use /test all to run the following jobs that were automatically triggered:
pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_br_integration_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_integration_e2e_test
pingcap/tidb/pull_mysql_client_test
In response to this:

/test tidb_parser_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

BornChanger · 2025-02-28T11:53:59Z

/retest

tiprow · 2025-02-28T11:54:22Z

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

add log restore ts into snapshot checkpoint metadata

8fa1d0b

Signed-off-by: Jianjun Liao <[email protected]>

ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Feb 20, 2025

BornChanger mentioned this pull request Feb 15, 2025

br: add table filter for Pitr restore #57613

Open

6 tasks

Tristan1900 approved these changes Feb 25, 2025

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 25, 2025

BornChanger approved these changes Feb 28, 2025

View reviewed changes

ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 28, 2025

ti-chi-bot bot merged commit 4297e12 into pingcap:master Feb 28, 2025
28 of 29 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

br: add log restore ts into snapshot checkpoint metadata #59678

br: add log restore ts into snapshot checkpoint metadata #59678

Leavrth commented Feb 20, 2025 •

edited

Loading

tiprow bot commented Feb 20, 2025

codecov bot commented Feb 20, 2025 •

edited

Loading

Tristan1900 left a comment

ti-chi-bot bot commented Feb 28, 2025

ti-chi-bot bot commented Feb 28, 2025

BornChanger commented Feb 28, 2025

ti-chi-bot bot commented Feb 28, 2025

tiprow bot commented Feb 28, 2025

tiprow bot commented Feb 28, 2025

BornChanger commented Feb 28, 2025

tiprow bot commented Feb 28, 2025

br: add log restore ts into snapshot checkpoint metadata #59678

br: add log restore ts into snapshot checkpoint metadata #59678

Conversation

Leavrth commented Feb 20, 2025 • edited Loading

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

tiprow bot commented Feb 20, 2025

codecov bot commented Feb 20, 2025 • edited Loading

Codecov Report

Tristan1900 left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Feb 28, 2025

ti-chi-bot bot commented Feb 28, 2025

[LGTM Timeline notifier]

BornChanger commented Feb 28, 2025

ti-chi-bot bot commented Feb 28, 2025

tiprow bot commented Feb 28, 2025

tiprow bot commented Feb 28, 2025

BornChanger commented Feb 28, 2025

tiprow bot commented Feb 28, 2025

Leavrth commented Feb 20, 2025 •

edited

Loading

codecov bot commented Feb 20, 2025 •

edited

Loading