Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: correct behavior of non-lite InitStats and stats sync load of no stats column (#57803) #59590

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57803

What problem does this PR solve?

Issue Number: close #57804

Problem Summary:

What changed and how does it work?

You can regard this pull request as a totally rewrite of #53399 and #53298

This pull reduced the possible stats state after the stats initialization finished. Now we'll get the same memory objects after a non-concurrent or current non-lite load.

Then use the unified status to make the ColumnIsLoadNeeded correct when one column even has no record in mysql.stats_histograms.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Feb 17, 2025
@ti-chi-bot
Copy link
Member Author

@winoros This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 17, 2025
@winoros winoros force-pushed the cherry-pick-57803-to-release-7.5 branch from 2921a2f to a050387 Compare February 25, 2025 19:49
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 25, 2025
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 25, 2025
@winoros winoros force-pushed the cherry-pick-57803-to-release-7.5 branch from 1ca28a1 to 597b0cc Compare February 26, 2025 16:42
@winoros
Copy link
Member

winoros commented Feb 26, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2025
Copy link

ti-chi-bot bot commented Feb 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 26, 2025
Copy link

ti-chi-bot bot commented Feb 26, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-25 20:07:52.109539543 +0000 UTC m=+386420.062697804: ☑️ agreed by hawkingrei.
  • 2025-02-26 16:43:28.379217517 +0000 UTC m=+460556.332375783: ☑️ agreed by winoros.

@winoros
Copy link
Member

winoros commented Feb 26, 2025

/retest

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-7.5@2934832). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #59590   +/-   ##
================================================
  Coverage               ?   72.1569%           
================================================
  Files                  ?       1417           
  Lines                  ?     413809           
  Branches               ?          0           
================================================
  Hits                   ?     298592           
  Misses                 ?      95208           
  Partials               ?      20009           
Flag Coverage Δ
unit 72.1569% <91.6666%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9400% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.5103% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot merged commit da5eed3 into pingcap:release-7.5 Feb 26, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants