-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: correct behavior of non-lite InitStats and stats sync load of no stats column (#57803) #59590
statistics: correct behavior of non-lite InitStats and stats sync load of no stats column (#57803) #59590
Conversation
@winoros This PR has conflicts, I have hold it. |
…d of no stats column(pingcap#57803)
2921a2f
to
a050387
Compare
1ca28a1
to
597b0cc
Compare
/unhold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #59590 +/- ##
================================================
Coverage ? 72.1569%
================================================
Files ? 1417
Lines ? 413809
Branches ? 0
================================================
Hits ? 298592
Misses ? 95208
Partials ? 20009
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This is an automated cherry-pick of #57803
What problem does this PR solve?
Issue Number: close #57804
Problem Summary:
What changed and how does it work?
You can regard this pull request as a totally rewrite of #53399 and #53298
This pull reduced the possible stats state after the stats initialization finished. Now we'll get the same memory objects after a non-concurrent or current non-lite load.
Then use the unified status to make the
ColumnIsLoadNeeded
correct when one column even has no record in mysql.stats_histograms.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.