prefetch: the prefetch buffer should be fully filled #59496
Conversation
Signed-off-by: lance6716 <[email protected]>
ti-chi-bot
bot
added
release-note-none
|
Hi @lance6716. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: lance6716 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #59496 +/- ##
================================================
+ Coverage 72.9945% 73.3910% +0.3965%
================================================
Files 1693 1693
Lines 468009 468842 +833
================================================
+ Hits 341621 344088 +2467
+ Misses 105364 103755 -1609
+ Partials 21024 20999 -25
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, D3Hunter The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/retest |
|
@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -54,14 +55,20 @@ func (r *Reader) run() { | |||
| for { | |||
| r.bufIdx = (r.bufIdx + 1) % 2 | |||
| buf := r.buf[r.bufIdx] | |||
| n, err := r.r.Read(buf) | |||
| n, err := io.ReadFull(r.r, buf) | |||
There was a problem hiding this comment.
Do we need add comment to explain why read will not return the err?
There was a problem hiding this comment.
err is saved in r.err in line 72. And in line 89 it will be returned to user
|
/cherry-pick release-8.1 |
|
/cherry-pick release-8.5 |
|
@lance6716: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
@lance6716: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #59495
Problem Summary:
What changed and how does it work?
use
io.ReadFullto fully fill the bufferCheck List
Tests
performance increased in a AWS manual test
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.