executor: fix forget to release session (#56299) #59481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
do-not-merge/hold
13 tasks
|
@lance6716 This PR has conflicts, I have hold it. |
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
size/XXL
tangenta
force-pushed
the
cherry-pick-56299-to-release-6.5
branch
from
eb0c533 to
43f24dd
Compare
ti-chi-bot
bot
added
size/S
tangenta
approved these changes
Feb 12, 2025
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
tangenta
removed
the
do-not-merge/hold
lance6716
approved these changes
Feb 13, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #59481 +/- ##
================================================
Coverage ? 73.6433%
================================================
Files ? 1098
Lines ? 353508
Branches ? 0
================================================
Hits ? 260335
Misses ? 76439
Partials ? 16734 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #56299
What problem does this PR solve?
Issue Number: close #56271
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.