Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: avoid throw error when data contains invalid date value #59375

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

winoros
Copy link
Member

@winoros winoros commented Feb 10, 2025

What problem does this PR solve?

Issue Number: close #56480

Problem Summary:

What changed and how does it work?

Mannuly solve it in released branch.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. cherry-pick-approved Cherry pick PR approved by release team. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved labels Feb 10, 2025
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-6.5@161ca53). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #59375   +/-   ##
================================================
  Coverage               ?   74.1935%           
================================================
  Files                  ?       1098           
  Lines                  ?     357302           
  Branches               ?          0           
================================================
  Hits                   ?     265095           
  Misses                 ?      75643           
  Partials               ?      16564           

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 11, 2025
Copy link

ti-chi-bot bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AilinKid,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 12, 2025
Copy link

ti-chi-bot bot commented Feb 12, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-11 05:13:43.342285333 +0000 UTC m=+333465.738507565: ☑️ agreed by AilinKid.
  • 2025-02-12 16:35:22.845598726 +0000 UTC m=+460765.241820791: ☑️ agreed by hawkingrei.

@winoros
Copy link
Member Author

winoros commented Feb 13, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit f46ced6 into pingcap:release-6.5 Feb 13, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants