executor: change the evaluation order of columns in Update and Insert statements (#57123)

[ti-chi-bot]

This is an automated cherry-pick of #57123

What problem does this PR solve?

Issue Number: ref #56829

Problem Summary:

In the previous logic, when we use UPDATE or INSERT ON DUPLICATE, the new row will be generated in the following order:

• Fill all the explicitly set columns.
• Evaluate all auto-generated columns. For UPDATE and INSERT, they are evaluated in composeGeneratedColumns and doDupRowUpdate respectively.
• Update on-update-now columns if necessary.

However, auto-generated columns may rely on the on-update-now columns to generate value. For example in #56829 (comment)

CREATE TABLE cache (
  cache_key varchar(512) NOT NULL,
  updated_at datetime NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,
  expired_at datetime GENERATED ALWAYS AS (if(expires > 0, date_add(updated_at, interval expires second), date_add(updated_at, interval 99 year))) VIRTUAL,
  expires int(11),
  PRIMARY KEY (cache_key) /*T![clustered_index] CLUSTERED */,
  KEY idx_c_on_expired_at (expired_at)
);

expired_at is generated based on the latest timestamp value from updated_at. So we will get wrong expired_at value. Even worse, expired_at is the part of the index idx_c_on_expired_at. So querying data expired_at using index scan and full table scan will get different result, since in full table scan, expired_at is calculated in real-time.

This also explains #56829 (comment) why changing VIRTUAL to STORED will not yield such error, although this value itself is incorrect.

What changed and how does it work?

To address this problem, this PR refactor the logic of INSERT ON DUPLICATE and UPDATE. More specifically:

• Move the evalation of auto-generated columns in updateRecord.
• ForeignKey Check is also moved into updateRecord.
• Extract errorHandler function for UPDATE and INSERT to handle error/warning in updateRecord.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[codecov]

Codecov Report

Attention: Patch coverage is 80.97166% with 47 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@7362832). Learn more about missing BASE report.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-8.5     #58708   +/-   ##
================================================
  Coverage               ?   57.0240%           
================================================
  Files                  ?       1770           
  Lines                  ?     628726           
  Branches               ?          0           
================================================
  Hits                   ?     358525           
  Misses                 ?     246066           
  Partials               ?      24135           

Flag	Coverage Δ
integration	36.9721% <79.3522%> (?)
unit	72.6967% <63.5627%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.8711% <0.0000%> (?)
parser	∅ <0.0000%> (?)
br	52.1007% <0.0000%> (?)

[joechenrh]

/retest

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wjhuang2016, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [YangKeao,wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2025-01-09 02:25:28.466177702 +0000 UTC m=+406871.755009407: ☑️ agreed by YangKeao.
• 2025-01-09 02:44:09.055989064 +0000 UTC m=+407992.344820766: ☑️ agreed by wjhuang2016.