-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add sql variable @@tidb_accelerate_user_creation_update #58512
Conversation
Hi @tiancaiamao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #58512 +/- ##
================================================
+ Coverage 73.0495% 74.7787% +1.7291%
================================================
Files 1690 1736 +46
Lines 467261 476082 +8821
================================================
+ Hits 341332 356008 +14676
+ Misses 104958 97597 -7361
- Partials 20971 22477 +1506
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (2)
- pkg/privilege/privileges/BUILD.bazel: Language not supported
- pkg/privilege/privileges/tidb_auth_token_test.go: Evaluated as low risk
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Frank945946, lance6716, lcwangchao, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #55563
Problem Summary:
What changed and how does it work?
Add a switch to control the behavior.
If @@tidb_accelerate_user_creation_update = off, use the old behavior, i.e. load all the user data
If @@tidb_accelerate_user_creation_update = on, only load the active user
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.