Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add sql variable @@tidb_accelerate_user_creation_update #58512

Merged
merged 9 commits into from
Feb 12, 2025

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #55563

Problem Summary:

What changed and how does it work?

Add a switch to control the behavior.
If @@tidb_accelerate_user_creation_update = off, use the old behavior, i.e. load all the user data
If @@tidb_accelerate_user_creation_update = on, only load the active user

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 24, 2024
Copy link

tiprow bot commented Dec 24, 2024

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.7787%. Comparing base (7515439) to head (66a0ebb).
Report is 4 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58512        +/-   ##
================================================
+ Coverage   73.0495%   74.7787%   +1.7291%     
================================================
  Files          1690       1736        +46     
  Lines        467261     476082      +8821     
================================================
+ Hits         341332     356008     +14676     
+ Misses       104958      97597      -7361     
- Partials      20971      22477      +1506     
Flag Coverage Δ
integration 48.7874% <88.8888%> (?)
unit 72.2366% <94.4444%> (-0.0019%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 60.5565% <ø> (+15.0563%) ⬆️

Copy link

ti-chi-bot bot commented Jan 24, 2025

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 11, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 12, 2025
@lance6716 lance6716 requested a review from Copilot February 12, 2025 01:45

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • pkg/privilege/privileges/BUILD.bazel: Language not supported
  • pkg/privilege/privileges/tidb_auth_token_test.go: Evaluated as low risk
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 12, 2025
Copy link

ti-chi-bot bot commented Feb 12, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-12 01:43:58.055329961 +0000 UTC m=+407280.451552023: ☑️ agreed by lcwangchao.
  • 2025-02-12 01:54:04.797384806 +0000 UTC m=+407887.193606867: ☑️ agreed by lance6716.

Copy link

ti-chi-bot bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Frank945946, lance6716, lcwangchao, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 12, 2025
@ti-chi-bot ti-chi-bot bot merged commit 397b0f2 into pingcap:master Feb 12, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants